Skip to content

Commit

Permalink
Fixes issue #73
Browse files Browse the repository at this point in the history
When running Robolectric tests we would get the following error:
`java.lang.IllegalAccessError: tried to access class kotlin.jvm.internal.DefaultConstructorMarker from class androidx.appcompat.widget.MaterialRecyclerViewPopupWindow$Companion`.

Additional changes:
- changed visibility of some internal classes i.e. `MaterialRecyclerViewPopupWindow` & `SectionedRecyclerViewAdapter` as they were not meant to be exposed anyway
- update Gradle & AGP versions
- target API version 28 -> 29
- moved `SanityTest` to `sharedTest` source set so that it can be tested with Robolectric as well
  • Loading branch information
Piotr Zawadzki authored and zawadz88 committed Nov 21, 2020
1 parent 777bb86 commit 6a1e847
Show file tree
Hide file tree
Showing 42 changed files with 113 additions and 684 deletions.
10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [4.1.0]
### Fixed
- Robolectric test failures (issue #73)

### Changed
- changed visibility of some internal classes i.e. `MaterialRecyclerViewPopupWindow` & `SectionedRecyclerViewAdapter` as they were not meant to be exposed anyway
- target API version 28 -> 29

## [4.0.1]
### Fixed
Expand Down Expand Up @@ -112,7 +119,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Added
Initial release of the library.

[Unreleased]: https://github.com/zawadz88/MaterialPopupMenu/compare/4.0.1...HEAD
[Unreleased]: https://github.com/zawadz88/MaterialPopupMenu/compare/4.1.0...HEAD
[4.1.0]: https://github.com/zawadz88/MaterialPopupMenu/compare/4.0.1...4.1.0
[4.0.1]: https://github.com/zawadz88/MaterialPopupMenu/compare/4.0.0...4.0.1
[4.0.0]: https://github.com/zawadz88/MaterialPopupMenu/compare/3.4.0...4.0.0
[3.4.0]: https://github.com/zawadz88/MaterialPopupMenu/compare/3.3.0...3.4.0
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This library allows to create simple popup menus programmatically with a nice [t

## Download (from JCenter)
```groovy
implementation 'com.github.zawadz88.materialpopupmenu:material-popup-menu:4.0.1'
implementation 'com.github.zawadz88.materialpopupmenu:material-popup-menu:4.1.0'
```

## Getting started
Expand Down
25 changes: 13 additions & 12 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
buildscript {
ext.KOTLIN_VERSION = '1.3.21'
ext.ANDROID_GRADLE_PLUGIN_VERSION = '3.3.2'
ext.ANDROID_GRADLE_PLUGIN_VERSION = '4.1.0'
ext.DOKKA_VERSION = '0.9.18'
ext.BINTRAY_VERSION = '1.8.4'
ext.KORDAMP_VERSION = '0.15.1'
Expand Down Expand Up @@ -33,9 +33,9 @@ allprojects {
configure(allprojects) {
ext {
ANDROID_MIN_SDK_VERSION = 19
ANDROID_TARGET_SDK_VERSION = 28
ANDROID_COMPILE_SDK_VERSION = 28
ANDROID_BUILD_TOOLS_VERSION = '28.0.3'
ANDROID_TARGET_SDK_VERSION = 29
ANDROID_COMPILE_SDK_VERSION = 29
ANDROID_BUILD_TOOLS_VERSION = '29.0.2'

ANDROIDX_CORE_VERSION = '1.0.1'
ANDROIDX_ANNOTATION_VERSION = '1.0.0'
Expand All @@ -44,18 +44,19 @@ configure(allprojects) {

ANDROIDX_CONSTRAINTLAYOUT_VERSION = '1.1.3'
ANDROIDX_CORE_KTX_VERSION = '1.1.0'
MATERIAL_COMPONENTS_VERSION = '1.2.0-alpha02'
MATERIAL_COMPONENTS_VERSION = '1.2.1'

JUNIT_VERSION = '4.12'
ARCHUNIT_VERSION = '0.12.0'
JUNIT_VERSION = '4.13.1'
ARCHUNIT_VERSION = '0.14.1'
HAMCREST_VERSION = '1.3'
MOCKITO_KOTLIN_VERSION = '2.1.0'

ANDROIDX_TEXT_CORE_VERSION = "1.2.0"
RUNNER_VERSION = "1.2.0"
RULES_VERSION = "1.2.0"
ESPRESSO_VERSION = "3.2.0"
JUNIT_EXT_VERSION = "1.1.0"
ANDROIDX_TEST_CORE_VERSION = "1.3.0"
RUNNER_VERSION = "1.3.0"
RULES_VERSION = "1.3.0"
ESPRESSO_VERSION = "3.3.0"
JUNIT_EXT_VERSION = "1.1.2"
ROBOLECTRIC_VERSION = "4.4"
}
}

8 changes: 0 additions & 8 deletions docs/material-popup-menu/alltypes/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,6 @@ <h3>All Types</h3>
</tr>
<tr>
<td>
<a href="../com.github.zawadz88.materialpopupmenu.internal/-sectioned-recycler-view-adapter/index.html">com.github.zawadz88.materialpopupmenu.internal.SectionedRecyclerViewAdapter</a></td>
<td>
<p>An extension to RecyclerView.Adapter to provide sections with headers to a
RecyclerView. Each section can have an arbitrary number of items.</p>
</td>
</tr>
<tr>
<td>
<a href="../com.github.zawadz88.materialpopupmenu/-view-bound-callback/index.html">com.github.zawadz88.materialpopupmenu.ViewBoundCallback</a></td>
<td>
<p>Callback to be invoked once the custom item view gets created and bound.
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

26 changes: 0 additions & 26 deletions docs/material-popup-menu/androidx.appcompat.widget/index.html

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 6a1e847

Please sign in to comment.