Add a way to customize popup padding #44
Conversation
| @@ -7,6 +7,10 @@ | |||
| <item name="mpm_secondaryTextColor">@color/mpm_black_54_opacity</item> | |||
| <item name="mpm_activeIconColor">@color/mpm_black_54_opacity</item> | |||
| <item name="mpm_separatorColor">@color/mpm_black_12_opacity</item> | |||
| <item name="mpm_paddingBottom">@dimen/mpm_popup_menu_vertical_padding</item> | |||
There was a problem hiding this comment.
Since this is the default and padding is now set programmatically in MaterialRecyclerViewPopupWindow then the following lines can be removed from mpm_popup_menu.xml:
android:paddingTop="@dimen/mpm_popup_menu_vertical_padding"
android:paddingBottom="@dimen/mpm_popup_menu_vertical_padding"
| @@ -316,6 +316,23 @@ class DarkActivity : AppCompatActivity() { | |||
| popupMenu.show(this@DarkActivity, view) | |||
| } | |||
|
|
|||
| @OnClick(R.id.customPaddingTextView) | |||
There was a problem hiding this comment.
Thanks for adding a sample as well!
There was a problem hiding this comment.
No problem, although I would suggest you to try and combine Dark/Light activities and their layouts. Right now adding new items to sample is kind of annoying since you have to add everything 2 times. Base abstract class with methods that ask for correct style where necessary could be enough.
But that's just a small suggestion :)
There was a problem hiding this comment.
I agree with you. I mean, that's what I would normally do in a normal project.
However, I've noticed that the more complicated the sample app is the higher the likelihood that people won't follow what's going on (had some weird questions on some other projects on GitHub...). That's why I went for this awful duplication in the first place :/
It is easier, for complete beginners especially, to just look at the sample code and e.g. copy it to your project.
|
Fixed all issues |
Added few attributes that allow users to customize the popup padding via style:
mpm_paddingBottommpm_paddingLeftmpm_paddingRightmpm_paddingTopExample