Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable clipToPadding on menu RecyclerView #54

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Disable clipToPadding on menu RecyclerView #54

merged 1 commit into from
Apr 17, 2019

Conversation

Tunous
Copy link
Contributor

@Tunous Tunous commented Apr 16, 2019

This change makes it so the popup content isn't clipped to the padding when scrolled.

Before After
Screenshot_1555436905 Screenshot_1555436887

@zawadz88
Copy link
Owner

Thanks! I'll take a look tomorrow and get back to you!
Unless you can check that on KitKat as well - I think that the 9-patch there has some padding added and I'm a bit worried how this will look there i.e. if the content doesn't appear outside of the menu box on a shadow.

zawadz88
zawadz88 approved these changes Apr 17, 2019
View reviewed changes
Copy link
Owner

@zawadz88 zawadz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix!

@zawadz88 zawadz88 merged commit 7b4dd2d into zawadz88:master Apr 17, 2019
@Tunous Tunous deleted the feature/clip-to-padding branch April 17, 2019 16:33
@zawadz88 zawadz88 mentioned this pull request Apr 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zawadz88 zawadz88 zawadz88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tunous @zawadz88