Release/4.0.0 #64
Merged
Release/4.0.0 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 3, 2019 16:47
…thod so that it's possible to override values set by it in callbacks. Updated `MaterialPopupMenuBuilder.SectionHolder.label` and `MaterialPopupMenuBuilder.ItemHolder.label` to be of type `CharSequence` rather than `String` to allow the use of `Spannables`. Prepared for release 4.0.0.
This can be used e.g. so that the popup menu has the same width as the anchor view. There was a sample added for this use case. This solves issue #62
Added an option to set a fixed width of the popup menu. This can be used e.g. so that the popup menu has the same width as the anchor view. There was a sample added for this use case. To achieve this effect an option to override offset was also added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.0.0]
Changed
mpm_paddingLeftwithmpm_paddingStartandmpm_paddingRightwithmpm_paddingEndand other inter layout attributes accordingly for better RTL supportMaterialPopupMenuBuilder.SectionHolder.labelandMaterialPopupMenuBuilder.ItemHolder.labelto be of typeCharSequencerather thanStringto allow the use ofSpannables.super.bindItemcall to the end ofItemViewHolder#bindItemmethod so that it's possible to override values set by it in callbacks.Added
MaterialPopupMenuBuildere.g. to achieve the following