Change Card.Marshal* methods to not use pointer receiver

zchenyu · Apr 18, 2021 · e080b3a · e080b3a
1 parent a9cd225
commit e080b3a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/card.go b/card.go
@@ -59,11 +59,11 @@ func NewCards(s string) []Card {
   return cards
 }
 
-func (c *Card) MarshalText() ([]byte, error) {
+func (c Card) MarshalText() ([]byte, error) {
 	return []byte(c.String()), nil
 }
 
-func (c *Card) MarshalJSON() ([]byte, error) {
+func (c Card) MarshalJSON() ([]byte, error) {
 	return []byte("\"" + c.String() + "\""), nil
 }
 

diff --git a/card_test.go b/card_test.go
@@ -1,6 +1,7 @@
 package cards
 
 import (
+	"encoding"
 	"encoding/json"
 	"testing"
 
@@ -22,6 +23,15 @@ func TestNewCards(t *testing.T) {
 	assert.Equal(t, []Card{Card(268446761), Card(134224677)}, NewCards("AhKs"))
 }
 
+func TestMarshalText(t *testing.T) {
+	var c encoding.TextMarshaler
+	c = NewCard("Ah")
+
+	b, err := c.MarshalText()
+	assert.NoError(t, err)
+	assert.Equal(t, "Ah", string(b))
+}
+
 func TestMarshalJSON(t *testing.T) {
 	cards := []Card{
 		NewCard("Ah"),