Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matcher.Matches() fails with a basedir of "." #3

Closed
hairyhenderson opened this issue Aug 23, 2021 · 1 comment
Closed

Matcher.Matches() fails with a basedir of "." #3

hairyhenderson opened this issue Aug 23, 2021 · 1 comment

Comments

@hairyhenderson
Copy link

The Matcher.Matches method errors when given . as the basedir. This may be expected behaviour (and may well be desirable so that xignore doesn't need to call os.Getwd), but it's undocumented.

See hairyhenderson/gomplate#1082 for a bit of background on how I found it (and worked around it).

I'm not sure if this is something that xignore should handle, but it should at least be documented 😉

@zealic
Copy link
Owner

zealic commented Oct 8, 2021

I see you was processed this issue in hairyhenderson/gomplate#1082 .

I think this issue should really be handled by the caller, because the library does not know the context of the calling scene and cannot control it.
I'm glad you already dealt with this issue.

I will add document for this api context.

zealic added a commit that referenced this issue Oct 8, 2021
@zealic zealic closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants