Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build on Windows (invalid RC path from winres dependency) #18393

Closed
1 task done
0hDEADBEAF opened this issue Sep 26, 2024 · 0 comments · Fixed by #18402
Closed
1 task done

Cannot build on Windows (invalid RC path from winres dependency) #18393

0hDEADBEAF opened this issue Sep 26, 2024 · 0 comments · Fixed by #18402
Labels
bug [core label] open source Open source community projects, contributions, etc windows

Comments

@0hDEADBEAF
Copy link
Contributor

0hDEADBEAF commented Sep 26, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I get the following error when building zed:

error: failed to run custom build command for `zed v0.154.2 (C:\Users\USER\src\zed\crates\zed)`

Caused by:
  process didn't exit successfully: `C:\Users\USER\src\zed\target\debug\build\zed-b24f1e9300107efc\build-script-build` (exit code: 1)
  --- stdout
  cargo:rerun-if-changed=../../.git/logs/HEAD
  cargo:rustc-env=ZED_COMMIT_SHA=25e2e9c6727ba9b77415588cfa11fd969612adb7
  cargo:rustc-link-arg=/stack:8388608
  cargo:rerun-if-changed=resources/windows/app-icon.ico
  package.metadata.winresource does not exist
  Selected RC path: 'bin\x64\rc.exe'

  --- stderr
  The system cannot find the path specified. (os error 3)
warning: build failed, waiting for other jobs to finish...

Here are the commands to reproduce the bug:

rustup update
git clone https://github.com/zed-industries/zed
cd zed
git checkout tags/v0.154.2
cargo run

Investigation:

I believe this is the same error as the one described here.
Building zed from my personal laptop works fine but building it on my work laptop doesn't. This is probably due to the IT security rules, as in the comment I've posted above.

Is it possible to bypass that problem? Maybe providing manually the RC path through the command line instead of letting it be deduced from registry values?

Environment

Device specifications:

Device name USER
Full device name USER.MYCOMPANY.com
Processor AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics 3.30 GHz
Installed RAM 32,0 GB (31,3 GB usable)
System type 64-bit operating system, x64-based processor
Pen and touch Touch support with 10 touch points

Windows specifications:

Edition Windows 11 Enterprise
Version 22H2
Installed on ‎28/‎05/‎2024
OS build 22621.4037
Experience Windows Feature Experience Pack 1000.22700.1027.0

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

@0hDEADBEAF 0hDEADBEAF added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Sep 26, 2024
@notpeter notpeter added windows open source Open source community projects, contributions, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Sep 26, 2024
SomeoneToIgnore pushed a commit that referenced this issue Sep 30, 2024
Closes #18393 

Release Notes:

- Added a `ZED_RC_TOOLKIT_PATH` env variable so `winresource` crate can fetch the RC executable path correctly on some configurations
noaccOS pushed a commit to noaccOS/zed that referenced this issue Oct 19, 2024
Closes zed-industries#18393 

Release Notes:

- Added a `ZED_RC_TOOLKIT_PATH` env variable so `winresource` crate can fetch the RC executable path correctly on some configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] open source Open source community projects, contributions, etc windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants