Go support not working at all #4471

nikitavoloboev · 2023-09-16T10:24:29Z

Check for existing issues

Completed

Describe the feature

Opened this project in Zed: https://github.com/nikitavoloboev/sol-pay

Opened this file: https://github.com/nikitavoloboev/sol-pay/blob/main/main.go

In Zed:

In VSCode:

No idea what I am doing wrong. But I wish I could use Zed for Go code too.

ConradIrwin · 2023-09-18T15:19:24Z

@nikitavoloboev Thanks for sharing the issue!

I found that this repo worked for me when I opened it in Zed:

I am worried that there must be something different between our computers causing this.

To help us debug, would you mind opening this repo, and then doing cmd-shift-p debug: Open Language Server Logs and pasting any logs generated while trying to complete here?

nikitavoloboev · 2023-09-18T16:14:09Z

https://gist.github.com/nikitavoloboev/5be6fb1411bb857dcce7156c7fa3cc80

here it is

I got the logs after doing this in a file

ConradIrwin · 2023-09-18T20:22:04Z

Sorry for giving you poor instructions, these are unfortunately the logs for the tailwind language server.

At the top of the screen after going to cmd-shift-p debug: Open Language Server Logs there is a dropdown selector for which language. You'll need to select "Go language server (sol-pay)" and it should look like this:

nikitavoloboev · 2023-09-19T07:37:29Z

@ConradIrwin

I think Go language server never got started as I don't see it here.

ConradIrwin · 2023-09-19T14:31:41Z

Bizarre. Thanks for checking. Is the language set to Go in the buffer? Conrad

…

On Tue, Sep 19, 2023 at 1:37 AM, Nikita ***@***.***> wrote: @ConradIrwin <https://github.com/ConradIrwin> I think Go language server never got started as I don't see it here. [image: image] <https://user-images.githubusercontent.com/6391776/268876885-35791731-a1a3-4c53-8f24-c746dffef187.png> — Reply to this email directly, view it on GitHub <#4471>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAXAQHGLDKM34GOY3XBGK3X3FDULANCNFSM6AAAAAA42ZNFBM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

nikitavoloboev · 2023-09-19T14:34:34Z

Yes

nikitavoloboev · 2023-09-19T14:35:11Z

actually i think it started downloading go lsp

now it gives this error

nikitavoloboev · 2023-09-19T14:35:40Z

I think that means I need to create a go workspaces file at ~/src?

ConradIrwin · 2023-09-19T14:47:03Z

@nikitavoloboev thanks for the screenshot!

This is caused by a poor handling of multiple go modules in go-pls (with a confusing error message to add to the confusion).

For more information see here: https://github.com/golang/tools/blob/master/gopls/doc/workspace.md, but TLDR you should be able to fix this by adding a go.work file at the top level that contains a list of directories containing modules and then running cmd-shift-p editor: Restart Language Server.

# go.work
go 1.21.1

use (
  ./go/sol-pay
  ./other/modules/...
)

Do you have the same issue in VSCode? If not I think we need to figure out how they work around this and copy that.

JosephTLyons · 2023-09-23T01:14:19Z

Thanks for jumping in here to help @ConradIrwin - appreciate it!

vxxvvxxv · 2024-02-09T10:54:52Z

@ConradIrwin
Hello! I have an error when Zed tryied to download Language server:

Language server error: Go

failed to parse gopls version output

mrnugget · 2024-02-09T12:28:46Z

@vxxvvxxv what do you get when you run ls ~/Library/Application\ Support/Zed/languages/gopls/?

In my case, I see the gopls binary in there:

$ ls ~/Library/Application\ Support/Zed/languages/gopls/
gobin        gopls_0.14.2

Do you also have that? If so, what's the output when you run it with version as an arg? Like this:

$ ~/Library/Application\ Support/Zed/languages/gopls/gopls_0.14.2 version
golang.org/x/tools/gopls v0.14.2
    golang.org/x/tools/[email protected] h1:sIw6vjZiuQ9S7s0auUUkHlWgsCkKZFWDHmrge8LYsnc=

SomeoneToIgnore · 2024-02-09T13:17:01Z

Also interesting to know the version it fails on — we did release a new binary yesterday, that included a fix for #7534 with the exact same error.

vxxvvxxv · 2024-02-09T14:16:01Z

@mrnugget I got this:

ls ~/Library/Application\ Support/Zed/languages/gopls/
gobin

@SomeoneToIgnore Zed notified me about auto-update, and after restarting, I have a new version (Zed 0.121.7).
After that, I wanted to open a Golang project for the first time and got this error.

I also tried downloading the latest release from GitHub, dragged Zed to Applications, opened it, and got the same thing.

Logs from Zed:

2024-02-09T20:08:56+06:00 [INFO] Opening main db
2024-02-09T20:09:06+06:00 [INFO] starting language server "gopls", path: "/Users/user/golang-project", id: 1
2024-02-09T20:09:15+06:00 [INFO] reload git repository ".git"
2024-02-09T20:09:16+06:00 [INFO] reload git repository ".git"
2024-02-09T20:09:17+06:00 [ERROR] crates/zed/src/languages/go.rs:358: no cached binary
2024-02-09T20:09:17+06:00 [ERROR] failed to start language server "gopls": failed to parse gopls version output
2024-02-09T20:09:17+06:00 [ERROR] server stderr: Some("")
2024-02-09T20:09:17+06:00 [ERROR] crates/zed/src/languages/go.rs:358: no cached binary
2024-02-09T20:09:17+06:00 [INFO] About to spawn test binary
2024-02-09T20:09:17+06:00 [WARN] test binary failed to launch
2024-02-09T20:09:17+06:00 [WARN] test binary check failed
2024-02-09T20:09:17+06:00 [INFO] beginning to reinstall server
2024-02-09T20:09:17+06:00 [INFO] deleting server container
2024-02-09T20:09:17+06:00 [INFO] starting language server "gopls", path: "/Users/user/golang-project", id: 2
2024-02-09T20:09:28+06:00 [ERROR] crates/zed/src/languages/go.rs:358: no cached binary
2024-02-09T20:09:28+06:00 [ERROR] failed to start language server "gopls": failed to parse gopls version output
2024-02-09T20:09:28+06:00 [ERROR] server stderr: Some("")
2024-02-09T20:09:28+06:00 [ERROR] crates/zed/src/languages/go.rs:358: no cached binary
2024-02-09T20:09:28+06:00 [INFO] About to spawn test binary
2024-02-09T20:09:28+06:00 [WARN] test binary failed to launch
2024-02-09T20:09:28+06:00 [WARN] test binary check failed
2024-02-09T20:09:28+06:00 [INFO] beginning to reinstall server
2024-02-09T20:09:28+06:00 [INFO] deleting server container
2024-02-09T20:09:28+06:00 [INFO] starting language server "gopls", path: "/Users/user/golang-project", id: 3
2024-02-09T20:09:33+06:00 [ERROR] crates/zed/src/languages/go.rs:358: no cached binary
2024-02-09T20:09:33+06:00 [ERROR] failed to start language server "gopls": failed to parse gopls version output
2024-02-09T20:09:33+06:00 [ERROR] server stderr: Some("")
2024-02-09T20:09:33+06:00 [ERROR] crates/zed/src/languages/go.rs:358: no cached binary
2024-02-09T20:09:33+06:00 [INFO] About to spawn test binary
2024-02-09T20:09:33+06:00 [WARN] test binary failed to launch
2024-02-09T20:09:33+06:00 [WARN] test binary check failed
2024-02-09T20:09:33+06:00 [INFO] beginning to reinstall server
2024-02-09T20:09:33+06:00 [INFO] deleting server container
2024-02-09T20:09:33+06:00 [INFO] starting language server "gopls", path: "/Users/user/golang-project", id: 4
2024-02-09T20:09:41+06:00 [ERROR] crates/zed/src/languages/go.rs:358: no cached binary
2024-02-09T20:09:41+06:00 [ERROR] failed to start language server "gopls": failed to parse gopls version output
2024-02-09T20:09:41+06:00 [ERROR] server stderr: Some("")
2024-02-09T20:09:41+06:00 [ERROR] crates/zed/src/languages/go.rs:358: no cached binary
2024-02-09T20:09:41+06:00 [INFO] About to spawn test binary
2024-02-09T20:09:41+06:00 [WARN] test binary failed to launch
2024-02-09T20:09:41+06:00 [WARN] test binary check failed
2024-02-09T20:09:41+06:00 [INFO] beginning to reinstall server
2024-02-09T20:09:41+06:00 [INFO] deleting server container
2024-02-09T20:09:41+06:00 [INFO] starting language server "gopls", path: "/Users/user/golang-project", id: 5
2024-02-09T20:09:49+06:00 [ERROR] crates/zed/src/languages/go.rs:358: no cached binary
2024-02-09T20:09:49+06:00 [ERROR] failed to start language server "gopls": failed to parse gopls version output
2024-02-09T20:09:49+06:00 [ERROR] server stderr: Some("")
2024-02-09T20:09:49+06:00 [ERROR] Hit 4 reinstallation attempts for "gopls"

SomeoneToIgnore · 2024-02-09T14:26:01Z

This is very weird: just did rm -rf ~/Library/Application\ Support/Zed/languages/gopls/, opened a random go project with Zed 0.121.7, witnessed it downloading the binary and starting gopls successfully afterwards.

So it looks like we have the logic for checking go releases right but it does not work for you due to either some local network issues (doubtfully, since you're able to post here) or some GitHub rate limiting mechanism?

Unfortunately, that failed to parse gopls version output error is super uninformative, I'll add something better there right now.
Would you be able to build Zed from source and run it on a go project? cargo run project/directory/path from Zed source tree would be enough.

If not, then I could only suggest to wait a bit and try later: https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28 states that it allows 60 requests/hour for unauthenticated users.
Or, you could try to inspect Zed's traffic with external utilities and see what it gets in response from GitHub, if that's an option for you.

SomeoneToIgnore · 2024-02-09T14:31:45Z

Thinking of it more, it is not actually a network error at this point?
It tries to start the server but somehow fails to get the output from it in the format it expects.

@vxxvvxxv
What if you also remove/move the ~/Library/Application\ Support/Zed/languages/gopls directory and try a fresh start?

vxxvvxxv · 2024-02-09T14:43:14Z

I just deleted the gopls directory and Zed downloaded it again, which looks correct.
But the error is the same.
Also connected a VPN, to check the file download, same result.

Unfortunately, I haven't seen any internet problems, nor do I think I'm catching Rate Limit (~5000 rps) from GitHub.

@SomeoneToIgnore
Now I will try to run Zed from the source.

Part of #4471 (comment) Improves gopls error logging to actually see what is wrong with the output we failed to match against the version regex. Release Notes: - N/A

SomeoneToIgnore · 2024-02-09T14:45:15Z

Thank you for trying all that.

Great timing, please do a git pull before that so #7614 is in, that should be more descriptive, hopefully.

Apparently, that gopls that's being installed is somehow not conformant with the regex that's used to fetch the version.

vxxvvxxv · 2024-02-09T14:53:26Z

Thank you, yes I did before running git pull and the latest changes came in.

I followed all the steps that are described here:
https://github.com/zed-industries/zed/blob/main/docs/src/developing_zed__building_zed.md
but got an error on trying to do a cargo run:

cargo run
    Updating git repository `https://github.com/tree-sitter/tree-sitter`
error: failed to load source for dependency `tree-sitter`

Caused by:
  Unable to update https://github.com/tree-sitter/tree-sitter?rev=1d8975319c2d5de1bf710e7e21db25b0eee4bc66#1d897531

Caused by:
  failed to fetch into: /Users/sokol/.cargo/git/db/tree-sitter-60edc5fae03f2366

Caused by:
  failed to authenticate when downloading repository: ssh://[email protected]/tree-sitter/tree-sitter

  * attempted ssh-agent authentication, but no usernames succeeded: `git`

  if the git CLI succeeds then `net.git-fetch-with-cli` may help here
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

Caused by:
  no authentication methods succeeded

SomeoneToIgnore · 2024-02-09T14:57:37Z

I think we could be onto something that breaks the gopls installation for you.
The error in question is the cargo one, related to odd combination of git settings and/or credentials related to those settings, but may also influence the way gopls is fetched?
rust-lang/cargo#3381 or related things could help, but I cannot provide anything specific due to zero clues about your local configs.

Glad to continue debugging after you deal with that one.

SomeoneToIgnore · 2024-02-09T15:04:20Z

Alternative track to try, if cargo seems too alien: this is the code that tries to install gopls and run it with version command:

zed/crates/zed/src/languages/go.rs

Lines 119 to 137 in f3bfa11

    
           let gobin_dir = container_dir.join("gobin"); 
        
           fs::create_dir_all(&gobin_dir).await?; 
        
           let install_output = process::Command::new("go") 
        
               .env("GO111MODULE", "on") 
        
               .env("GOBIN", &gobin_dir) 
        
               .args(["install", "golang.org/x/tools/gopls@latest"]) 
        
               .output() 
        
               .await?; 
        
           anyhow::ensure!( 
        
               install_output.status.success(), 
        
               "failed to install gopls. Is `go` installed and in the PATH?" 
        
           ); 
        
           let installed_binary_path = gobin_dir.join("gopls"); 
        
           let version_output = process::Command::new(&installed_binary_path) 
        
               .arg("version") 
        
               .output() 
        
               .await 
        
               .context("failed to run installed gopls binary")?;

It should be more or less clear what it does from that piece, so you can try repro the CLI commands locally and see what is not right with gopls that gets fetched this way.

vxxvvxxv · 2024-02-09T15:30:26Z

Thank you! Yeah, that's what it's all about. I suppose it would be useful to add the Troubleshooting section.

echo '[net]\ngit-fetch-with-cli = true' >> ~/.cargo/config

The code seems correct. I am waiting to finish downloading dependencies for the cargo run command.

Also, I tried to run your command into bash and got this:

GO111MODULE=on \
GOBIN=/Users/sokol/Work/go/src/gitlab.com/zed-industries/tmp_g \
go install golang.org/x/tools/gopls@latest && \
/Users/sokol/Work/go/src/gitlab.com/zed-industries/tmp_g/gopls version

zsh: killed     /Users/sokol/Work/go/src/gitlab.com/zed-industries/tmp_g/gopls version

But if I try to run my locally gopls:

gopls version
golang.org/x/tools/gopls v0.14.2
    golang.org/x/tools/[email protected] h1:sIw6vjZiuQ9S7s0auUUkHlWgsCkKZFWDHmrge8LYsnc=

which gopls
/Users/sokol/Work/go/bin/gopls

Also, I tried to run the downloaded gopls from the Zed folder:

~/Library/Application\ Support/Zed/languages/gopls/gobin/gopls version
zsh: killed     ~/Library/Application\ Support/Zed/languages/gopls/gobin/gopls version

I'll post after I wait for the cargo run to be executed.

pstjean · 2024-02-09T16:47:38Z

~/Library/Application\ Support/Zed/languages/gopls/gobin/gopls version
zsh: killed     ~/Library/Application\ Support/Zed/languages/gopls/gobin/gopls version

I ran into this issue the other day, gopls was being compiled with an alternative llvm toolchain to the one Apple installs alongside Xcode. The underlying issue is documented here: golang/go/issues/63997

The issue is that the binary is not signed when compiled using this toolchain. Unsigned binaries are killed immediately on launch, which is the behavior we see here. I would try signing the Zed installed binary manually (see here).

mrnugget · 2024-03-14T16:28:56Z

I'm going to close this, since a lot has changed with our gopls integration since the last activity in this issue (we not detect whether it already exists in path, we use the shell env for that path, ...). So if a problem pops up again, let's open a new ticket (ideally more specific) or reopen this one.

pedronasser · 2024-03-25T15:42:17Z

I am still having issues with Zed and Gopls.

mrnugget · 2024-03-25T15:55:11Z

@pedronasser Can you create a new ticket and provide some debugging information?

quinn · 2024-04-26T16:21:18Z

I'm having this issue too. Not sure where to find debugging info, nothing shows in the log as far as I can tell

quinn · 2024-04-26T16:26:10Z

I don't seem to have the go lsp at all for some reason.

mrnugget · 2024-04-29T04:59:17Z

I'm having this issue too. Not sure where to find debugging info, nothing shows in the log as far as I can tell

You can also provide debugging information: what's the project setup? Do you use GOPATH? go.mod? Is it a monorepo?

Did you try go.work file? #10224 (comment)

quinn · 2024-04-29T18:53:16Z

I'm using go modules, I have a go.mod file. Its not a monorepo, go.mod/go.sum are in the project root. I do not have a go.work file, haven't heard of this before. I assume that I only need that if using a monorepo?

quinn · 2024-04-29T20:33:46Z

I just tried a totally fresh project (and installed gopls):

Is there any reason why the language server logs don't show up at all?

mrnugget · 2024-04-30T07:20:49Z

Use zed: open log or look in ~/Library/Logs/Zed/Zed.log for more information.

quinn · 2024-05-01T14:19:06Z

thanks @mrnugget I needed to asdf reshim 🤦

I found the error message in the logs. I had looked previously but must have missed it, tailing the log while it booted helped, rather than using zed: open log. I would love it if Zed alerted me when the lsp failed to boot, rather than failing silently.

mrnugget · 2024-05-02T07:49:44Z

I would love it if Zed alerted me when the lsp failed to boot, rather than failing silently.

Yeah that's a good point. Can you create a ticket with the relevant parts of the logs (meaning: shows where and why it failed) for this?

simonbanyard · 2024-05-07T20:29:27Z

If the version in go.mod has a patch version, it seems that the completions won't work. Changing it to display major. minor seems to fix the issue.

mrnugget · 2024-05-08T04:24:31Z

Yeah, that error comes from gopls and I also get it if I open a project with go 1.22.2 in Neovim, for example.

algoflows · 2024-05-16T22:33:17Z

not working for me either Golang is defunct with Zed.

mrnugget · 2024-05-17T07:38:19Z

Hey @algoflows! I can't do much with that analysis. Can you create a ticket with details on your setup, log output, etc., anything?

nikitavoloboev added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Sep 16, 2023

JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024

SomeoneToIgnore mentioned this issue Feb 9, 2024

Show better errors when failing to start golps #7614

Merged

mrnugget mentioned this issue Feb 16, 2024

Improved detection and re-use of language servers #7902

Closed

mrnugget closed this as completed Mar 14, 2024

Go support not working at all #4471

Go support not working at all #4471

Comments

nikitavoloboev commented Sep 16, 2023 • edited Loading

Check for existing issues

Describe the feature

ConradIrwin commented Sep 18, 2023

nikitavoloboev commented Sep 18, 2023

ConradIrwin commented Sep 18, 2023

nikitavoloboev commented Sep 19, 2023

ConradIrwin commented Sep 19, 2023 via email

nikitavoloboev commented Sep 19, 2023

nikitavoloboev commented Sep 19, 2023

nikitavoloboev commented Sep 19, 2023

ConradIrwin commented Sep 19, 2023

JosephTLyons commented Sep 23, 2023

vxxvvxxv commented Feb 9, 2024

mrnugget commented Feb 9, 2024

SomeoneToIgnore commented Feb 9, 2024

vxxvvxxv commented Feb 9, 2024

SomeoneToIgnore commented Feb 9, 2024 • edited Loading

SomeoneToIgnore commented Feb 9, 2024 • edited Loading

vxxvvxxv commented Feb 9, 2024

SomeoneToIgnore commented Feb 9, 2024

vxxvvxxv commented Feb 9, 2024 • edited Loading

SomeoneToIgnore commented Feb 9, 2024 • edited Loading

SomeoneToIgnore commented Feb 9, 2024 • edited Loading

vxxvvxxv commented Feb 9, 2024 • edited Loading

pstjean commented Feb 9, 2024 • edited Loading

mrnugget commented Mar 14, 2024

pedronasser commented Mar 25, 2024 • edited Loading

mrnugget commented Mar 25, 2024

quinn commented Apr 26, 2024

quinn commented Apr 26, 2024

mrnugget commented Apr 29, 2024

quinn commented Apr 29, 2024

quinn commented Apr 29, 2024

mrnugget commented Apr 30, 2024

quinn commented May 1, 2024

mrnugget commented May 2, 2024

simonbanyard commented May 7, 2024

mrnugget commented May 8, 2024

algoflows commented May 16, 2024

mrnugget commented May 17, 2024

nikitavoloboev commented Sep 16, 2023 •

edited

Loading

SomeoneToIgnore commented Feb 9, 2024 •

edited

Loading

SomeoneToIgnore commented Feb 9, 2024 •

edited

Loading

vxxvvxxv commented Feb 9, 2024 •

edited

Loading

SomeoneToIgnore commented Feb 9, 2024 •

edited

Loading

SomeoneToIgnore commented Feb 9, 2024 •

edited

Loading

vxxvvxxv commented Feb 9, 2024 •

edited

Loading

pstjean commented Feb 9, 2024 •

edited

Loading

pedronasser commented Mar 25, 2024 •

edited

Loading