Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript: Make it possible to use local vtsls #15775

Merged
merged 1 commit into from
Aug 6, 2024
Merged

typescript: Make it possible to use local vtsls #15775

merged 1 commit into from
Aug 6, 2024

Conversation

kakoc
Copy link
Contributor

@kakoc kakoc commented Aug 4, 2024 •
edited by osiewicz
Loading

Related things:
#7902
#4978

Release Notes:

  • VTSLS will now use local instance if there's one on PATH.

@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 4, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @kakoc on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@maxdeviant maxdeviant changed the title feat(vtsls): make possible to use local vtsls typescript: Make it possible to use local vtsls Aug 4, 2024
@zed-industries-bot
Copy link

zed-industries-bot commented Aug 4, 2024 •
edited
Loading

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- (Added|Fixed|Improved) ... ([#<public_issue_number_if_exists>](https://github.com/zed-industries/zed/issues/<public_issue_number_if_exists>)).

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against 2010b52

@kakoc kakoc force-pushed the feat/vtsls/add_check_if_user_installed branch from 6eacbd0 to f87c65b Compare August 4, 2024 16:36
@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 4, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @kakoc on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@kakoc
feat(vtsls): make possible to use local vtsls
2010b52 
Release Notes:
- Added: positibily to use locally installed vtsls
@kakoc kakoc force-pushed the feat/vtsls/add_check_if_user_installed branch from f87c65b to 2010b52 Compare August 4, 2024 16:37
@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 4, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @kakoc on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@kakoc
Copy link
Contributor Author

kakoc commented Aug 4, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 4, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 4, 2024

The cla-bot has been summoned, and re-checked this pull request!

@osiewicz osiewicz merged commit f4a58e5 into zed-industries:main Aug 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@osiewicz osiewicz

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kakoc @zed-industries-bot @osiewicz