Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to embed-resource 3.0 (fixes build below windows \?\ path) #21288

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Update to embed-resource 3.0 (fixes build below windows \?\ path) #21288

merged 1 commit into from
Nov 29, 2024

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented Nov 28, 2024 •
edited by SomeoneToIgnore
Loading

Accd'g to #9009 (comment) the manifest is required

Followup for nabijaczleweli/rust-embed-resource#71

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 28, 2024
@zed-industries-bot
Copy link

zed-industries-bot commented Nov 28, 2024 •
edited
Loading

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A
Messages
📖

This PR includes links to the following GitHub Issues: #nabijaczleweli/rust-embed-resource#71
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against da44262

SomeoneToIgnore
SomeoneToIgnore approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@SomeoneToIgnore SomeoneToIgnore merged commit 74f265e into zed-industries:main Nov 29, 2024
12 checks passed
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Nov 29, 2024
Merged
@SomeoneToIgnore
Copy link
Contributor

A note for the future: every time you touch dependencies in Cargo.toml, you have to ensure Cargo.lock gets updated.
#21328

SomeoneToIgnore added a commit that referenced this pull request Nov 29, 2024
@SomeoneToIgnore
Update the lockfile after a recent dependency update (#21328)
a593a04 
Follow-up of #21288

Release Notes:

- N/A
JaLnYn pushed a commit to JaLnYn/zed that referenced this pull request Nov 29, 2024
@nabijaczleweli @JaLnYn
Update to embed-resource 3.0 (fixes build below windows \?\ path) (ze…
f2f814e 
…d-industries#21288)

Accd'g to
zed-industries#9009 (comment)
the manifest is required

Followup for
nabijaczleweli/rust-embed-resource#71

Release Notes:
- N/A
JaLnYn pushed a commit to JaLnYn/zed that referenced this pull request Nov 29, 2024
@SomeoneToIgnore @JaLnYn
Update the lockfile after a recent dependency update (zed-industries#…
677710a 
…21328)

Follow-up of zed-industries#21288

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneToIgnore SomeoneToIgnore SomeoneToIgnore approved these changes

Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabijaczleweli @zed-industries-bot @SomeoneToIgnore