Add ability to specify binary path/args for rust-analyzer #9293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
This fixes #9292 by adding a section to the language server settings that allows users to specify the binary path and arguments with which to start up a language server. Example user settings for `rust-analyzer`: ```json { "lsp": { "rust-analyzer": { "binary": { "path": "/Users/thorstenball/tmp/rust-analyzer-aarch64-apple-darwin", "arguments": ["--no-log-buffering"] } } } } ``` Right now this only allows ABSOLUTE paths. Co-authored-by: Ricard Mallafre <[email protected]>
mrnugget
force-pushed
the
rust-analyzer-path-args
branch
from
ac7b3f2 to
5117404
Compare
mrnugget
added a commit
that referenced
this pull request
Mar 26, 2024
This uses the language server settings added in #9293 to allow users to specify the binary path and arguments with which to start up `gopls`. Example user settings for `gopls`: ```json { "lsp": { "gopls": { "binary": { "path": "/Users/thorstenball/tmp/gopls", "arguments": ["-debug=0.0.0.0:8080"] }, } } } ``` Constraints: * Right now this only allows ABSOLUTE paths. Release Notes: - Added ability to specify `gopls` binary `path` (must be absolute) and `arguments` in user settings. Example: `{"lsp": {"gopls": {"binary": {"path": "/my/abs/path/gopls", "arguments": ["-debug=0.0.0.0:8080"] }}}}`
mrnugget
added a commit
that referenced
this pull request
Mar 26, 2024
This uses the language server settings added in #9293 to allow users to specify the binary path and arguments with which to start up `gopls`. Example user settings for `gopls`: ```json { "lsp": { "gopls": { "binary": { "path": "/Users/thorstenball/tmp/gopls", "arguments": ["-debug=0.0.0.0:8080"] }, } } } ``` Constraints: * Right now this only allows ABSOLUTE paths. Release Notes: - Added ability to specify `gopls` binary `path` (must be absolute) and `arguments` in user settings. Example: `{"lsp": {"gopls": {"binary": {"path": "/my/abs/path/gopls", "arguments": ["-debug=0.0.0.0:8080"] }}}}`
pjlast
pushed a commit
to pjlast/zed
that referenced
this pull request
Mar 26, 2024
) This uses the language server settings added in zed-industries#9293 to allow users to specify the binary path and arguments with which to start up `gopls`. Example user settings for `gopls`: ```json { "lsp": { "gopls": { "binary": { "path": "/Users/thorstenball/tmp/gopls", "arguments": ["-debug=0.0.0.0:8080"] }, } } } ``` Constraints: * Right now this only allows ABSOLUTE paths. Release Notes: - Added ability to specify `gopls` binary `path` (must be absolute) and `arguments` in user settings. Example: `{"lsp": {"gopls": {"binary": {"path": "/my/abs/path/gopls", "arguments": ["-debug=0.0.0.0:8080"] }}}}`
1 task
hferreiro
added a commit
to hferreiro/zed
that referenced
this pull request
Apr 16, 2024
This uses the language server settings added in zed-industries#9293 to allow users to specify the binary path and arguments with which to start up `clangd`. Example user settings for `clangd`: ```json { "lsp": { "clangd": { "binary": { "path": "/usr/bin/clangd", "arguments": ["--log=verbose"] }, } } } ``` Constraints: * Right now this only allows ABSOLUTE paths. Release Notes: - Added ability to specify `clangd` binary `path` (must be absolute) and `arguments` in user settings. Example: `{"lsp": {"clangd": {"binary": {"path": "/usr/bin/clangd", "arguments": ["--log=verbose"] }}}}`
mrnugget
pushed a commit
that referenced
this pull request
Apr 16, 2024
This uses the language server settings added in #9293 to allow users to specify the binary path and arguments with which to start up `clangd`. Example user settings for `clangd`: ```json { "lsp": { "clangd": { "binary": { "path": "/usr/bin/clangd", "arguments": ["--log=verbose"] }, } } } ``` Constraints: * Right now this only allows ABSOLUTE paths. Release Notes: - Added ability to specify `clangd` binary `path` (must be absolute) and `arguments` in user settings. Example: `{"lsp": {"clangd": {"binary": {"path": "/usr/bin/clangd", "arguments": ["--log=verbose"] }}}}`
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9292 by adding a section to the language server settings that allows users to specify the binary path and arguments with which to start up a language server.
Example user settings for
rust-analyzer:{ "lsp": { "rust-analyzer": { "binary": { "path": "/Users/thorstenball/tmp/rust-analyzer-aarch64-apple-darwin", "arguments": ["--no-log-buffering"] } } } }Constraints:
rust-analyzerintegration right now, but the setting can be used for other language servers. We just need to update the adapters to also respect that setting.Release Notes:
rust-analyzerbinarypath(must be absolute) andargumentsin user settings. Example:{"lsp": {"rust-analyzer": {"binary": {"path": "/my/abs/path/rust-analyzer", "arguments": ["--no-log-buffering"] }}}}(#9292).