Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing tips on RenamePane or RenameTab mode #1010

Closed
dswij opened this issue Jan 15, 2022 · 2 comments
Closed

Confusing tips on RenamePane or RenameTab mode #1010

dswij opened this issue Jan 15, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dswij
Copy link
Contributor

dswij commented Jan 15, 2022

When in RenamePane or RenameTab mode, the tips is <Enter> when done / <ENTER> Select pane, which is confusing since there are two <ENTER> action

image
@jaeheonji
Copy link
Member

Obviously, the <ENTER> Select pane part can be confusing.
It seems that that phrase can be modified in the status-bar plugin.

In the details, the following functions in seconds_line.rs:

  • full_shortcut_list
  • shortened_shortcut_list
  • best_effort_shortcut_list

I'll make this a good first issue for now!

@jaeheonji jaeheonji added good first issue Good for newcomers enhancement New feature or request labels Jan 15, 2022
@RobWalt RobWalt mentioned this issue Feb 7, 2022
Merged
jaeheonji added a commit that referenced this issue Feb 8, 2022
@RobWalt @jaeheonji
Solve Issue #1010 (#1045)
341a9f4 
* solve issue #1010 and made code easily extensible

* Make description bold to fit + added minimal documentation

* chore(assets): update plugins

* Only change hints on reneamPane Mode, old hints were fine in every other case

* fixing some wording to get more green e2e tests

* add the opt version of the plugin

Co-authored-by: jaeheonji <[email protected]>
@RobWalt
Copy link
Contributor

RobWalt commented Feb 8, 2022

@jaeheonji This can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RobWalt @jaeheonji @dswij