Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Added PluginAwareInterface and marked EventsCapableInterface as deprecated #177

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Added PluginAwareInterface and marked EventsCapableInterface as deprecated #177

wants to merge 5 commits into from

Conversation

boesing
Copy link
Member

@boesing boesing commented Sep 13, 2018

Since the StorageFactory only checks for the EventsCapableInterface, it would result in a Call to undefined method WhateverStorage::hasPlugin.

Therefore, I would like to introduce that PluginAwareInterface for ZF3 and until then, I would like to mark the EventsCapableInterface usage as deprecated and provide this backport request.

@boesing boesing changed the title Added PluginManagerAwareInterfac and marked EventsCapableInterface as deprecated Added PluginManagerAwareInterface and marked EventsCapableInterface as deprecated Sep 13, 2018
@boesing boesing changed the title Added PluginManagerAwareInterface and marked EventsCapableInterface as deprecated Added PluginAwareInterface and marked EventsCapableInterface as deprecated Sep 13, 2018
@boesing boesing changed the title Added PluginAwareInterface and marked EventsCapableInterface as deprecated [WIP] Added PluginAwareInterface and marked EventsCapableInterface as deprecated Sep 13, 2018
@froschdesign
Copy link
Member

@boesing
The target version is 2.9?

@boesing
Copy link
Member Author

boesing commented Sep 13, 2018

@froschdesign I'm not sure since I did not got into those release processes already. If thats a change for 2.8, I could change the target branch to master

@froschdesign
Copy link
Member

froschdesign commented Sep 13, 2018

No no, the develop branch is correct!

I looked at the code and thought that it is for version 3 and then I saw the deprecation info. A deprecation goes in the next minor release.

@froschdesign froschdesign added this to the 2.9.0 milestone Sep 13, 2018
@boesing boesing changed the title [WIP] Added PluginAwareInterface and marked EventsCapableInterface as deprecated Added PluginAwareInterface and marked EventsCapableInterface as deprecated Sep 14, 2018
@boesing
Copy link
Member Author

boesing commented Sep 17, 2018

I guess this PR is ready to merge now @froschdesign, would be great if you drop the WIP label. Thanks.

@froschdesign froschdesign removed the WIP label Sep 17, 2018
@boesing
Copy link
Member Author

boesing commented Aug 12, 2019

I really could need this PR in my latest project boesing/zend-cache-redis-cluster as I want to work with that PluginCapableInterface::getPluginRegistry to determine search for the serializer plugin.

I guess anything is on hold until we have more news about laminas?

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-cache; a new issue has been opened at laminas/laminas-cache#2.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-cache. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-cache to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-cache.
  • In your clone of laminas/laminas-cache, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants