This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fixing issue #100 withHeader does not remove old header value #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need a test case |
| @@ -204,6 +204,9 @@ public function withHeader($header, $value) | |||
| $normalized = strtolower($header); | |||
|
|
|||
| $new = clone $this; | |||
| if($new->hasHeader($header)) { | |||
| unset($new->headers[$new->headerNames[$normalized]]); | |||
There was a problem hiding this comment.
I wonder if this could be done always and remove the if
There was a problem hiding this comment.
The problem there is, if $new->headerNames[$normalized]doesn't exist PHP will throw a warning.
I guess we could not use $new->hasHeader() and directly call array_key_exists($normilized, $new->headerNames).
What do you think?
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
Fixing issue #100 withHeader does not remove old header value
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to fix Issue #100