Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Added support for utf8 path #166

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Conversation

agoosev
Copy link
Contributor

@agoosev agoosev commented Mar 29, 2016

Currently, we can't work with non-latin letters in path. For example: http://example.com/тестовый_путь/ or http://example.com/flüg/. I resolve this problem by adding in CHAR_UNRESERVED constant \pL for support utf-8 letters.

@zf2timo
Copy link

zf2timo commented Mar 29, 2016

Looks similar to #155

An Unit Test with UTF-8 Characters was already added in #159.

@agoosev
Copy link
Contributor Author

agoosev commented Mar 29, 2016

@zf2timo, yes, but #155 covers only cases with utf8 domains. In this pull request I covered cases with utf8 path of url.

@zf2timo
Copy link

zf2timo commented Mar 29, 2016

@agoosev you are right.

@weierophinney weierophinney added this to the 1.3.6 milestone Sep 7, 2016
@weierophinney weierophinney self-assigned this Sep 7, 2016
@weierophinney weierophinney merged commit 722d6df into zendframework:master Sep 7, 2016
weierophinney added a commit that referenced this pull request Sep 7, 2016
Added support for utf8 path
weierophinney added a commit that referenced this pull request Sep 7, 2016
weierophinney added a commit that referenced this pull request Sep 7, 2016
weierophinney added a commit that referenced this pull request Sep 7, 2016
@weierophinney
Copy link
Member

Thanks, @agoosev!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants