This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Serialize into array #219
Merged
Serialize into array #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it ok I will make serializer for response. What are you think about deserializers from arrays? |
|
@snapshotpl would segregate it to a separate serializer or interface (implementation can be added to existing one, but ISP must be respected IMO) |
|
@Ocramius as it's static method interface doesn't sense here imo. |
|
Misread it, good point. Indeed, statics don't need interfaces.
…On 28 Dec 2016 8:01 p.m., "Witold Wasiczko" ***@***.***> wrote:
@Ocramius <https://github.com/Ocramius> as it's static method interface
doesn't sense here imo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#219 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakD3OM_faQ4jiI0I8SQ04nvQt0jFWks5rMrHtgaJpZM4LXDR0>
.
|
|
What about array deserializer idea? |
|
I would create
The purpose of the current serializers is specifically for string de/serialization, and the methods exposed reflect that purpose. New classes specifically for array de/serialization make sense here. |
|
@weierophinney @Ocramius ready to review |
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2017
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2017
|
Merged to develop for release with 1.4.0; thanks, @snapshotpl |
jesseschalken
added a commit
to ivt/zend-diactoros
that referenced
this pull request
May 15, 2017
zend-diactoros 1.4.0 Added ----- - [zendframework#219](zendframework#219) adds two new classes, `Zend\Diactoros\Request\ArraySerializer` and `Zend\Diactoros\Response\ArraySerializer`. Each exposes the static methods `toArray()` and `fromArray()`, allowing de/serialization of messages from and to arrays. - [zendframework#236](zendframework#236) adds two new constants to the `Response` class: `MIN_STATUS_CODE_VALUE` and `MAX_STATUS_CODE_VALUE`. Changes ------- - [zendframework#240](zendframework#240) changes the behavior of `ServerRequestFactory::fromGlobals()` when no `$cookies` argument is present. Previously, it would use `$_COOKIES`; now, if a `Cookie` header is present, it will parse and use that to populate the instance instead. This change allows utilizing cookies that contain period characters (`.`) in their names (PHP's built-in cookie handling renames these to replace `.` with `_`, which can lead to synchronization issues with clients). - [zendframework#235](zendframework#235) changes the behavior of `Uri::__toString()` to better follow proscribed behavior in PSR-7. In particular, prior to this release, if a scheme was missing but an authority was present, the class was incorrectly returning a value that did not include a `//` prefix. As of this release, it now does this correctly. Deprecated ---------- - Nothing. Removed ------- - Nothing. Fixed ----- - Nothing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me it's useful when I want to serialize messages to log using psr-4 (into context)