This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
[v2] Removed emitters and server - moved to zend-httphandlerrunner #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've created a release-2.0 branch for this, and updated the PR to base off of that. Some notes:
|
michalbundyra
changed the title
Classes are moved to zend-httphandlerrunner
Server class functionality is fulfilled by RequestHandlerRunner from that library
weierophinney
added a commit
that referenced
this pull request
May 29, 2018
|
Thanks, @webimpress! |
weierophinney
added a commit
to weierophinney/zend-diactoros
that referenced
this pull request
May 29, 2018
Per zendframework#295, these classes have equivalents or 1:1 mappings via the package zendframework/zend-httphandlerrunner. As such, they are deprecated for the 1.8.0 release, to be removed in version 2.0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have duplicated functionality in
zend-httphandlerrunner.In this PR classes from zend-httphandlerrunner are used instead, and local classes are removed.
This is just quick change, to start discussion what we should do with this package. Maybe the package should be splitted to smaller one, or just
Serverclass should be moved to another (new?) repository?