This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Reason phrase must be a string #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
suggested changes
Jul 19, 2018
src/Response.php
Outdated
|
|
||
| if (! is_string($reasonPhrase)) { | ||
| throw new InvalidArgumentException(sprintf( | ||
| 'Unsupported HTTP method; must be a string, received %s', |
There was a problem hiding this comment.
"Unsupported HTTP method"?
I'm thinking you mean "Unsupported response reason phrase" here.
src/Response.php
Outdated
| if (! is_string($reasonPhrase)) { | ||
| throw new InvalidArgumentException(sprintf( | ||
| 'Unsupported HTTP method; must be a string, received %s', | ||
| (is_object($reasonPhrase) ? get_class($reasonPhrase) : gettype($reasonPhrase)) |
There was a problem hiding this comment.
You can drop the surrounding parens; they're unneeded when providing an expression as a function argument.
test/ResponseTest.php
Outdated
| @@ -112,6 +112,13 @@ public function testCanSetCustomReasonPhrase() | |||
| $this->assertSame('Foo Bar!', $response->getReasonPhrase()); | |||
| } | |||
|
|
|||
| public function testCannotCreateReasonPhraseNotString() | |||
There was a problem hiding this comment.
Let's rephrase this to testWithStatusRaisesAnExceptionForNonStringReasonPhrases(). Additionally, please test it with other non-string values as well (using a data provider), to validate they all produce an exception.
weierophinney
force-pushed
the
reason-phrase
branch
from
4e5d88a to
2cf1797
Compare
weierophinney
added a commit
that referenced
this pull request
Jul 24, 2018
weierophinney
added a commit
that referenced
this pull request
Jul 24, 2018
weierophinney
added a commit
that referenced
this pull request
Jul 24, 2018
|
Thanks, @snapshotpl! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.