This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Create and use package exceptions everywhere #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch creates `Zend\Diactoros\Exception\ExceptionInterface`, a marker interface extending `Throwable`. It then creates the following package-specific exception types: - `Zend\Diactoros\Exception\DeserializationException` (extends `UnexpectedValueException`) - `Zend\Diactoros\Exception\InvalidArgumentException` (extends `InvalidArgumentException`) - `Zend\Diactoros\Exception\InvalidStreamPointerPositionException` (extends `RuntimeException`) - `Zend\Diactoros\Exception\SerializationException` (extends `UnexpectedValueException`) - `Zend\Diactoros\Exception\UnreadableStreamException` (extends `RuntimeException`) - `Zend\Diactoros\Exception\UnrecognizedProtocolVersionException` (extends `UnexpectedValueException`) - `Zend\Diactoros\Exception\UnrewindableStreamException` (extends `RuntimeException`) - `Zend\Diactoros\Exception\UnseekableStreamException` (extends `RuntimeException`) - `Zend\Diactoros\Exception\UntellableStreamException` (extends `RuntimeException`) - `Zend\Diactoros\Exception\UnwritableStreamException` (extends `RuntimeException`) - `Zend\Diactoros\Exception\UploadedFileAlreadyMovedException` (extends `RuntimeException`) - `Zend\Diactoros\Exception\UploadedFileErrorException` (extends `RuntimeException`) The various classes and functions raising exceptions are updated to throw these more specific types. The patch also removes `Zend\Diactoros\Exception\DeprecatedMethodException`, as it is no longer used.
weierophinney
added a commit
that referenced
this pull request
Sep 6, 2018
weierophinney
added a commit
that referenced
this pull request
Sep 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch creates
Zend\Diactoros\Exception\ExceptionInterface, a marker interface extendingThrowable. It then creates the following package-specific exception types:Zend\Diactoros\Exception\DeserializationException(extendsUnexpectedValueException)Zend\Diactoros\Exception\InvalidArgumentException(extendsInvalidArgumentException)Zend\Diactoros\Exception\InvalidStreamPointerPositionException(extendsRuntimeException)Zend\Diactoros\Exception\SerializationException(extendsUnexpectedValueException)Zend\Diactoros\Exception\UnreadableStreamException(extendsRuntimeException)Zend\Diactoros\Exception\UnrecognizedProtocolVersionException(extendsUnexpectedValueException)Zend\Diactoros\Exception\UnrewindableStreamException(extendsRuntimeException)Zend\Diactoros\Exception\UnseekableStreamException(extendsRuntimeException)Zend\Diactoros\Exception\UntellableStreamException(extendsRuntimeException)Zend\Diactoros\Exception\UnwritableStreamException(extendsRuntimeException)Zend\Diactoros\Exception\UploadedFileAlreadyMovedException(extendsRuntimeException)Zend\Diactoros\Exception\UploadedFileErrorException(extendsRuntimeException)The various classes and functions raising exceptions are updated to throw these more specific types.
The patch also removes
Zend\Diactoros\Exception\DeprecatedMethodException, as it is no longer used.This is primarily an internal improvement. However, it also gives users the ability to catch all package-specfic exceptions, or the more specific exception types, in addition to the types mandated by PSR-7 and PSR-17.