This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Bugfix: Header with value "0" is being discarded #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
that referenced
this pull request
Dec 20, 2018
|
Thanks, @malukenho! |
This was referenced Dec 21, 2018
Merged
|
This fix cause an issue in apache on win, because there is a header [SERVER_SIGNATURE] => That contains not "secured" data and it throws an exception and drop down our prod environment. It was really hard to find the root cause. And not only on windows(our prod env is debian lamp server) |
This was referenced Dec 28, 2018
|
This is not a proper fix - all server vars are copied as headers, which is incorrect. The problem users are reporting is when some of the server values can not be used as headers. This should probably be reverted and a simple |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking #342