This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Drop minimum required PHP version to 5.4 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drupal 8 has a minimum PHP of 5.4.8. Symfony 2.7 still depends on 5.3.something. 5.4 is a reasonable middle-ground to ensure that new libraries targeting older versions of PHP do not need to be written.
- The `::class` magic class constant was introduced with PHP 5.5, so cannot be used here if we want to provide 5.4 support.
|
This would eliminate one of the two blockers to Drupal pulling in the Symfony-PSR-7 bridge and Diactoros, so definitely +1 from me. (The other blocker is a question of scope and timing, which is not something Zend can do anything about.) |
|
It will increase the number of Symfony users and projects able to use the PSR-7 Bridge so 👍 |
weierophinney
added a commit
that referenced
this pull request
Jun 4, 2015
weierophinney
added a commit
that referenced
this pull request
Jun 4, 2015
weierophinney
added a commit
that referenced
this pull request
Jun 4, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal 8 has a minimum PHP of 5.4.8. Symfony 2.7 still depends on 5.3.something. 5.4 is a reasonable middle-ground to ensure that new libraries targeting older versions of PHP do not need to be written.
This will be a temporary change; we will likely update the minimum required version in one of the next few minor releases.