This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Use unescaped slashes in encoded JSON by default #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the default `$encodingOptions` to also include `JSON_UNESCAPED_SLASHES`, which is a sane default, and still complies with RFC 4627 (forward slash, or the solidus, does not need to be escaped).
| @@ -41,7 +42,7 @@ class JsonResponse extends Response | |||
| * @param int $encodingOptions JSON encoding options to use. | |||
| * @throws InvalidArgumentException if unable to encode the $data to JSON. | |||
| */ | |||
| public function __construct($data, $status = 200, array $headers = [], $encodingOptions = 15) | |||
| public function __construct($data, $status = 200, array $headers = [], $encodingOptions = 79) | |||
There was a problem hiding this comment.
That last hardcoded number bothers me a lot. Can it be moved to a class constant?
|
@Ocramius done. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the default
$encodingOptionsto also includeJSON_UNESCAPED_SLASHES, which is a sane default, and still complies with RFC 4627 (forward slash, or the solidus, does not need to be escaped).