This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Register only one error handler in swallowDeprecationNotices()
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrium
force-pushed
the
hotfix/404
branch
2 times, most recently
from
0b1ca49 to
910792d
Compare
weierophinney
approved these changes
Dec 8, 2016
| $handler = function ($errno, $errstr) { | ||
| if ($errno !== E_USER_DEPRECATED) { | ||
| return false; | ||
| $handler = function ($errno, $errstr, $errfile, $errline, $errcontext) use (&$previous) { |
There was a problem hiding this comment.
You'll need to define $previous prior to declaring this handler; references can sometimes lead to issues otherwise.
There was a problem hiding this comment.
I can make this change on merge.
weierophinney
added a commit
that referenced
this pull request
Dec 8, 2016
Register only one error handler in `swallowDeprecationNotices()`
weierophinney
added a commit
that referenced
this pull request
Dec 8, 2016
weierophinney
added a commit
that referenced
this pull request
Dec 8, 2016
|
Thanks, @adrium |
|
The PR might seem a bit fussy, but I like Expressive and that was something I could contribute :)
I am interested in what cases? I tested it with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handlers are not popped correctly in
__invoke():$handlerfromswallowDeprecationNotices()is still active after running the application which again swallows all errors afterZend\Expressive\Applicationfinished execution.The modified test passes for this commit, but it does not in the previous (but it should).
Edit: Would it be desired to also open a corresponding issue?