This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Respect JsonResponseHandler flags when false #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danizord
force-pushed
the
hotfix/whoops-json-flags
branch
2 times, most recently
from
c9c8d43 to
52cf541
Compare
geerteltink
approved these changes
Feb 11, 2017
danizord
force-pushed
the
hotfix/whoops-json-flags
branch
from
52cf541 to
76d2908
Compare
danizord
force-pushed
the
hotfix/whoops-json-flags
branch
from
76d2908 to
f2b3440
Compare
| @@ -75,11 +75,11 @@ private function registerJsonHandler(Whoops $whoops, $config) | |||
|
|
|||
| $handler = new JsonResponseHandler(); | |||
|
|
|||
| if (isset($config['json_exceptions']['show_trace'])) { | |||
| if (isset($config['json_exceptions']['show_trace']) && true === $config['json_exceptions']['show_trace']) { | |||
There was a problem hiding this comment.
Maybe we can have here ! empty? What do you think?
There was a problem hiding this comment.
Not sure, I think stricter is better :)
There was a problem hiding this comment.
! empty is functionally equivalent here, more succinct, and more in line with other similar checks against configuration flags we're doing elsewhere.
weierophinney
added a commit
that referenced
this pull request
Feb 13, 2017
Respect JsonResponseHandler flags when false
weierophinney
added a commit
that referenced
this pull request
Feb 13, 2017
weierophinney
added a commit
that referenced
this pull request
Feb 13, 2017
|
Thanks, @danizord! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you explicitly set the flags to false, it behaves as if it were true.