Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Updated webimpress/http-middleware-compatibility to 0.1.4 #523

Closed
wants to merge 3 commits into from
Closed

Updated webimpress/http-middleware-compatibility to 0.1.4 #523

wants to merge 3 commits into from

Conversation

michalbundyra
Copy link
Member

This version install also composer plugin which prompt user to install http-interop/http-middleware as explicit dependency in their composer.json.
It prompts only when http-interop/http-middleware is not installed, otherwise it use version currently installed to update composer.json and message with information how to update is shown in console.

See also #517 (comment)

This version install also composer plugin which prompt user to install
http-interop/http-middleware as explicit dependency in their composer.json
It prompts only when http-interop/http-middleware is not installed,
otherwise it use version currently installed to update composer.json
and message with information how to update is shown in console.
It requires `webimpress/composer-extra-dependency` with hotfixes:
  - disables plugin in non-interactive mode
  - disables scripts on internal install call
  - checks require-dev section for dependency

Removed flag `--no-plugins` in travis build configuration.
It is no longer required as `webimpress/composer-extra-dependency`
is not going to run in non-interactive mode.
@michalbundyra michalbundyra changed the title Updated webimpress/http-middleware-compatibility to 0.1.3 Updated webimpress/http-middleware-compatibility to 0.1.4 Oct 17, 2017
@vlakarados
Copy link

Can this be merged please? This is required for working with the latest stratigility and not working with deprecated http-interop/http-middleware

@michalbundyra
Copy link
Member Author

Closed in favour of #529

@michalbundyra michalbundyra deleted the hotfix/http-compat branch November 28, 2017 21:04
@vlakarados
Copy link

@webimpress sorry, but why would we do this together with 7.1 requirement?

@michalbundyra
Copy link
Member Author

@vlakarados PSR-15 is going to support only PHP 7.0+. Currently http-interop/http-server-middleware also supports only PHP 7.0+.

This is decision we have made in ZF, for more information please see:
https://discourse.zendframework.com/t/psr-15-compatibility-issues-and-proposal/378/10

@vlakarados
Copy link

@webimpress yes, but why it's 7.1 then? :)

@michalbundyra
Copy link
Member Author

@vlakarados See post on the forum.
It's said there:

Update the minimum PHP version to 7.1 (per our next major release milestone announcement)

It has been announced in June 2017.

This PR is not gonna go live. Instead we are going to have new MAJOR release with PSR-15 (~ early 2018) and alpha 3.0.0 probably this week.

@vlakarados
Copy link

@webimpress I see, too bad, but another reason and more motivation to upgrade to 7.1 :) Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants