This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
zend-diactoros is an optional dependency #580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be an optional dependency as in factories where it is used we checking for the class existance
Version 1.7.1 contains PSR-7 implementation hotfix, to return host name always lowercase, which follows IETF RFC 3986 section 3.2.2 (requires that the host name be normalized to lowercase)
We can use any implementation of psr/http-message-implementation
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2018
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2018
|
Merged with 75af35c. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everywhere where we are using diactoros we check first for class existence, so it should be an optional dependency.
Added conflict with version prior to 1.7.1 - see release notes for 1.7.1
Added to suggest section in composer.json.
Build is failing because of other issues on current release-3.0.0 branch - see #579