This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
Make StandaloneExtensionManagers configurable #55
Closed
Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
316e9b7
Merge branch 'hotfix/43'
weierophinney 5387abb
Make $extensions property protected
Synchro b9f3004
Switch to making StandaloneExtensionManager configurable
Synchro 1351b73
Not final
Synchro e09a172
Add tests for Writer StandaloneExtensionMananger
Synchro 7155b5a
No return value from remove, simplify
Synchro c431c49
Implement same changes for Writer
Synchro 7a91f4f
Use class pseudoconstants rather than strings for class names
Synchro 849b55d
Fix namespaced names
Synchro 8c3860f
Fix data provider
Synchro 223e867
Fix test provider namespaces
Synchro 4e68bee
Writer, not Reader
Synchro f807526
Fix data provider
Synchro f71a00c
Improve docs a little
Synchro d4a8efe
Add checks when adding extensions
Synchro a9a5af4
Use mock extension
Synchro ce6fd8b
Code style
Synchro 3e379f8
Fix wrong exceptions
Synchro 789b4b2
Fix wrong exception
Synchro 4096b6e
More tests
Synchro 1c80524
More tests
Synchro 32982ff
Break out tests
Synchro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason, why this check is removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not needed. unset will work the same and there is no distinction between removing instance and noop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xerkus
You are right, it throws no error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because
unset
is a language construct, not a real function, and it doesn't care whether the thing you're unsetting exists or not. The check was only there before to set the return value.