-
Notifications
You must be signed in to change notification settings - Fork 42
Added Reader/Writer methods and tests for <itunes:title> on entry level #96
Conversation
@podcasthosting |
* | ||
* @return string | ||
*/ | ||
public function getTitle() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmmh, a test class for the entire Zend\Feed\Reader\Extension\Podcast\Entry
is missing.
I will create a separate issue report for this problem.
@podcasthosting |
@OpenHaus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
(The coding standard is a separate topic and is related to the whole component.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@podcasthosting @OpenHaus
Please use the develop
branch for new features. Thanks!
Compare with: https://github.com/zendframework/zend-feed/blob/master/docs/PULL_REQUEST_TEMPLATE.md
It does not seem so. The uri referencing the DTD in the specs is not reachable:
I have no further information. |
Okay, thanks for the feedback anyway. 👍 |
Thanks, @podcasthosting! I rebased your branch against develop, and merged against develop for the upcoming 2.12.0 release. |
There is a (new) field in the Itunes podcast spec for the episode title.
See https://help.apple.com/itc/podcasts_connect/#/itcb54353390 > Episode descriptions > itunes:title
The pull requests adds the missing methods for reading and writing a feed and the tests.