Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Serbian Cyrillic pre-translated validation messages #11

Closed
wants to merge 8 commits into from

Conversation

sttewan
Copy link

@sttewan sttewan commented Oct 27, 2015

New sr_RS/Zend_Validate.php for Serbian Cyrillic pre-translated validation messages.

Stevan Radoičić added 6 commits October 27, 2015 03:53
Creating new sr_RS/Zend_Validate.php for Serbian Cyrillic pre-translated validation messages.
Create Zend_Validate.php
Updating sr_RS/Zend_Validate.php for Serbian Cyrillic pre-translated validation messages.
Update Zend_Validate.php
Creating sr_RS/Zend_Captcha.php for Serbian Cyrillic pre-translated validation messages.
Create Zend_Captcha.php
return array(
// Zend\Authentication\Validator\Authentication
"Invalid identity" => "Погрешан идентитет",
"Identity is ambiguous" => "Идентитет је сумњив",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this:

- сумњив
+ двосмислен

@nikolaposa thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"двосмислен" is OK

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"dvosmislen", "nejasan"...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to "двосмислен".

@ManInTheBox
Copy link

👍

return array(
// Zend\Captcha\ReCaptcha
"Missing captcha fields" => "Недостају captcha поља",
"Failed to validate captcha" => "Неуспела captcha валидација",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we imported this word as well https://sr.wikipedia.org/wiki/%D0%9A%D0%B0%D0%BF%D1%87%D0%B0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wut!? Rather NO in my opinion :D

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @ManInTheBox, you simply don't want to translate some words, i.e. web, captcha, server, framework (frejmvork), etc. :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolaposa Like file = датотека. :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to change here.

@nikolaposa
Copy link

I've noticed that in several cases, foreign words that cannot be translated, i.e. md5, hostname, DNS, and similar were left untouched, which is fine, but I suggest that they are surrounded with single quotation marks or such. For example:

  • Фајл не одговара датим 'crc32' вредностима
  • 'Мimеtype' фајла не може бити детектован.
  • Унос је 'DNS hostname' али дату 'punycode' нотацију је немогуће декодирати


// Zend\Validator\File\IsImage
"File is no image, '%type%' detected" => "Фајл није слика, '%type%' детектован",
"The mimetype could not be detected from the file" => "Мimеtype фајла не може бити детектован",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the above. Better not to use quotations for every foreign word.

Stevan Radoičić added 2 commits October 30, 2015 22:54
Updating sr_RS/Zend_Validate.php for Serbian Cyrillic pre-translated validation messages based on collaborative comments.
Update Zend_Validate.php
@sttewan
Copy link
Author

sttewan commented Oct 30, 2015

Above changes committed to local branch.

@Maks3w
Copy link
Member

Maks3w commented Nov 16, 2015

Any other objection? If not I guess this could be merged along the next days.

weierophinney added a commit that referenced this pull request Apr 30, 2018
Serbian Cyrillic pre-translated validation messages
weierophinney added a commit that referenced this pull request Apr 30, 2018
weierophinney added a commit that referenced this pull request Apr 30, 2018
@weierophinney
Copy link
Member

Thanks, @sttewan! Merged to develop for release with 2.6.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants