Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on the run_metadata changes #3193

Open
wants to merge 94 commits into
base: develop
Choose a base branch
from

Conversation

bcdurak
Copy link
Contributor

@bcdurak bcdurak commented Nov 13, 2024

Describe changes

This PR optimizes the way that we store run metadata related to different entities. (addresses the review comment here)

In our old implementation, when someone calls log_metadata, it is possible that they attach the same metadata to different entities such as pipeline runs, step runs, and model versions. While this is still possible, this process used to create X different entries with the same key-value pair in the metadata table.

In order to optimize this process, this PR separates the previous run metadata table into two tables:

  • One that holds the actual key-value pair.
  • One that links this pair to different resources.

For this to work, I also implemented a new RunMetadataRequest model, that can hold more than one entity per key-value pair. All the previous calls that used this request model, all affected models and schemas are adjusted accordingly.

Other related changes

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

AlexejPenner and others added 30 commits October 17, 2024 17:14
@github-actions github-actions bot added the enhancement New feature or request label Nov 13, 2024
@bcdurak bcdurak marked this pull request as ready for review November 13, 2024 17:34
@bcdurak
Copy link
Contributor Author

bcdurak commented Nov 13, 2024

@htahir1 It would be great if you could also take a look at the docs changes.

Copy link
Contributor

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

Copy link
Contributor

Classification template updates in examples/mlops_starter have been pushed.

Copy link
Contributor

E2E template updates in examples/e2e have been pushed.

Copy link
Contributor

NLP template updates in examples/e2e_nlp have been pushed.

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Just one small thing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you deletd this you might want to fix other links + add a redirect in .gitbook.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants