-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up on the run_metadata
changes
#3193
base: develop
Are you sure you want to change the base?
Conversation
…nto feature/better-metadata
…nto feature/better-metadata
…nto feature/better-metadata
…nto feature/better-metadata
…nto feature/better-metadata
@htahir1 It would be great if you could also take a look at the docs changes. |
LLM Finetuning template updates in |
Classification template updates in |
E2E template updates in |
NLP template updates in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Just one small thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you deletd this you might want to fix other links + add a redirect in .gitbook.yaml
Describe changes
This PR optimizes the way that we store run metadata related to different entities. (addresses the review comment here)
In our old implementation, when someone calls
log_metadata
, it is possible that they attach the same metadata to different entities such as pipeline runs, step runs, and model versions. While this is still possible, this process used to create X different entries with the same key-value pair in the metadata table.In order to optimize this process, this PR separates the previous run metadata table into two tables:
For this to work, I also implemented a new
RunMetadataRequest
model, that can hold more than one entity per key-value pair. All the previous calls that used this request model, all affected models and schemas are adjusted accordingly.Other related changes
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes