-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Need to clarify if required
means a required column OR also required valid data within column
#70
Comments
Provides the functionality to validate against a remote schema hosted on github by github reference (e.g. master HEAD, version tag, etc.). It also pulls out a "spec" as a class object to make it easier to pass around and abstract the differences between getting a spec from Github vs Local files. This PR also: - formats code per pre-commit - refactors apply_schema_to_df into smaller functions - updates errors and warning to be more helpful (pointing to files, etc) - adds tests for field constraints in constraint_tests.py - adds assert statements to basic_tests.py Closes #25 Closes #26 NOTE: Tests failing due to zephyr-data-specs/GMNS#70
Our intent was to use the term
Is the issue actually in the |
@dtemkin-volpe flagging for your work with frictionless. I know the python package has been updated since I made this comment last year, has it changed what it means by "required"? |
From what I can tell, "required" just means that the field can't be null, and "missingValues" is an array of values that when processed by the |
As an implementer of GMNS, I'd like to understand if the required constraint applies to values or columns (or both)
Frictionless spec is really just checking for the column presence and allows for missing values.
If we don't want missing values, then we need to assert pattern or enum or other constraints.
The text was updated successfully, but these errors were encountered: