Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP2: Apparent issues with client-side connections (hangs when server (apparently) closes connection). #27982

Closed
pfalcon opened this issue Sep 2, 2020 · 3 comments · Fixed by #28011
Closed

TCP2: Apparent issues with client-side connections (hangs when server (apparently) closes connection). #27982

pfalcon opened this issue Sep 2, 2020 · 3 comments · Fixed by #28011
Assignees
@jukkar @ozhuraki
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Sep 2, 2020

This is a kind of dual to #27876. While that dealt with Zephyr-as-server case, this is about Zephyr-as-client case, and samples/net/sockets/big_http_download sample.

When running that sample (frdm_k64f tested so far), I get:

Iteration 1 of INF
sock = 0
[00:00:03.000,000] <inf> net_config: Interface 1 (0x20000ef0) coming up
[00:00:03.001,000] <inf> eth_mcux: ETH_0 enabled 100M full-duplex mode.
[00:00:03.001,000] <inf> net_config: IPv4 address: 192.0.2.1
[00:00:03.001,000] <inf> net_config: Running dhcpv4 client...
Download progress: 7015896 Bytes; 6851 KiB; 6 MiB

At which point it hangs. Looks like another issue with FIN handling.

I tested this with and without #27960, the behavior is the same.
@pfalcon pfalcon added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug area: Networking labels Sep 2, 2020
@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 2, 2020

Ah, forgot to mention that:

Download progress: 7015896 Bytes

is exactly the size of the file being downloaded, http://archive.ubuntu.com:80/ubuntu/dists/xenial/main/installer-amd64/current/images/hd-media/vmlinuz

@jukkar jukkar added priority: medium Medium impact/importance bug and removed priority: high High impact/importance bug labels Sep 2, 2020
@jukkar
Copy link
Member

jukkar commented Sep 2, 2020

Not a high issue as there is a workaround.

@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 3, 2020

To confirm, the issue also happens with qemu_x86.

@pfalcon pfalcon mentioned this issue Sep 3, 2020
Closed
jukkar added a commit to jukkar/zephyr that referenced this issue Sep 3, 2020
@jukkar
net: tcp2: Fix connection close ack values
8342ca3 
If we receive a TCP segment with FIN | ACK | PSH flags, then
update the ack values properly.

Fixes zephyrproject-rtos#27982

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar jukkar mentioned this issue Sep 3, 2020
Merged
nashif pushed a commit that referenced this issue Sep 3, 2020
@jukkar @nashif
net: tcp2: Fix connection close ack values
9d064e6 
If we receive a TCP segment with FIN | ACK | PSH flags, then
update the ack values properly.

Fixes #27982

Signed-off-by: Jukka Rissanen <[email protected]>
@pfalcon pfalcon mentioned this issue Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

@ozhuraki ozhuraki

Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net: tcp2: Fix connection close ack values jukkar/zephyr
3 participants
@pfalcon @jukkar @ozhuraki