Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twister: program get stuck when serial in hardware map is empty string #41169

Closed
gopiotr opened this issue Dec 14, 2021 · 1 comment · Fixed by #43963
Closed

twister: program get stuck when serial in hardware map is empty string #41169

gopiotr opened this issue Dec 14, 2021 · 1 comment · Fixed by #43963
Assignees
Labels
area: Twister Twister bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@gopiotr
Copy link
Collaborator

gopiotr commented Dec 14, 2021

Describe the bug
When in hardware map serial option is set as empty string, the program do not rise any error - instead of this it goes forward and gets stuck into wait for device loop

To Reproduce
Steps to reproduce the behavior:

  1. Create hardware map file with serial option as empty string. For example like this:
- connected: true
  id: 0006
  platform: nrf52840dk_nrf52840
  product: J-Link
  runner: nrfjprog
  serial: ""
  1. Run Twister by command:
    scripts/twister --device-testing --hardware-map map.yml -T samples/hello_world/ -v -v
  2. Observe that program stuck into wait for device available loop:
DEBUG - Waiting for device nrf52840dk_nrf52840 to become available
DEBUG - Waiting for device nrf52840dk_nrf52840 to become available
DEBUG - Waiting for device nrf52840dk_nrf52840 to become available

Expected behavior
Program should rise en error (for not existing serial port).

Impact
Annoyance - program get stuck into wait loop and block tests performing.

Environment (please complete the following information):

  • Linux
  • Zephyr SDK
  • Commit SHA: 903c78c

Additional context
I already have proposition for fix this bug and I will create PR soon

@gopiotr gopiotr added the bug The issue is a bug, or the PR is fixing a bug label Dec 14, 2021
@nashif nashif added area: Twister Twister priority: low Low impact/importance bug labels Jan 11, 2022
@nashif nashif assigned nashif and gopiotr and unassigned nashif Jan 11, 2022
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Mar 13, 2022
gopiotr added a commit to gopiotr/zephyr that referenced this issue Mar 18, 2022
Modify serial and serial_pty option availability verification in DTU
object in device_is_available method to avoid situation when empty string
passed as serial in hardware_map.yaml cause hang up Twister in this
place.

Fixes: zephyrproject-rtos#41169

Signed-off-by: Piotr Golyzniak <[email protected]>
@nashif nashif removed the Stale label Mar 18, 2022
nashif pushed a commit that referenced this issue Mar 24, 2022
Modify serial and serial_pty option availability verification in DTU
object in device_is_available method to avoid situation when empty string
passed as serial in hardware_map.yaml cause hang up Twister in this
place.

Fixes: #41169

Signed-off-by: Piotr Golyzniak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Twister Twister bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
2 participants