Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PACS: Fix PAC capabilities to be exposed in PAC Sink/Source characteristic #43058

Closed
MariuszSkamra opened this issue Feb 22, 2022 · 0 comments
Closed

PACS: Fix PAC capabilities to be exposed in PAC Sink/Source characteristic #43058

MariuszSkamra opened this issue Feb 22, 2022 · 0 comments
Assignees
@MariuszSkamra
Labels
area: Bluetooth Audio area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@MariuszSkamra
Copy link
Collaborator

MariuszSkamra commented Feb 22, 2022 •
edited
Loading

Describe the bug
It looks like current implementation exposes codec configuration instead of capabilities in PACS Sink/Source characteristic value.

02-22 10:24:37.416 21383 21435 I bt_stack: [INFO:devices.cc(1253)] Registering PAC
02-22 10:24:37.416 21383 21435 I bt_stack:     Coding format: 0x06
02-22 10:24:37.416 21383 21435 I bt_stack:     Vendor codec company ID: 000000
02-22 10:24:37.416 21383 21435 I bt_stack:     Vendor codec ID: 000000
02-22 10:24:37.416 21383 21435 I bt_stack:     Codec spec caps:
02-22 10:24:37.416 21383 21435 I bt_stack:     type: 1    len: 1    data: 03
02-22 10:24:37.416 21383 21435 I bt_stack:     type: 2    len: 1    data: 01
02-22 10:24:37.416 21383 21435 I bt_stack:     type: 3    len: 4    data: 00000000
02-22 10:24:37.416 21383 21435 I bt_stack:     type: 4    len: 2    data: 2800
02-22 10:24:37.416 21383 21435 I bt_stack: 
02-22 10:24:37.416 21383 21435 I bt_stack:     Metadata: 03020200
@MariuszSkamra MariuszSkamra added the bug The issue is a bug, or the PR is fixing a bug label Feb 22, 2022
@MariuszSkamra MariuszSkamra self-assigned this Feb 22, 2022
@MariuszSkamra MariuszSkamra added area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth Audio labels Feb 22, 2022
@carlescufi carlescufi added area: Bluetooth priority: low Low impact/importance bug labels Feb 22, 2022
MariuszSkamra added a commit to MariuszSkamra/zephyr that referenced this issue Feb 23, 2022
@MariuszSkamra
samples: unicast_audio_server: Fix codec specific capabilities
8e76176 
This fixes format of codec specific capabilities in PAC record.

Fixes: zephyrproject-rtos#43058
Signed-off-by: Mariusz Skamra <[email protected]>
MariuszSkamra added a commit to MariuszSkamra/zephyr that referenced this issue Feb 23, 2022
@MariuszSkamra
tests: bsim: unicast_server_test: Fix codec specific capabilities
536a7b1 
This fixes format of codec specific capabilities in PAC record.

Fixes: zephyrproject-rtos#43058
Signed-off-by: Mariusz Skamra <[email protected]>
mbolivar-nordic pushed a commit that referenced this issue Feb 25, 2022
@MariuszSkamra @mbolivar-nordic
tests: bsim: unicast_server_test: Fix codec specific capabilities
57ad6af 
This fixes format of codec specific capabilities in PAC record.

Fixes: #43058
Signed-off-by: Mariusz Skamra <[email protected]>
RodinHaker pushed a commit to abelsensors/zephyr that referenced this issue Mar 19, 2022
@MariuszSkamra @RodinHaker
samples: unicast_audio_server: Fix codec specific capabilities
e8de6f0 
This fixes format of codec specific capabilities in PAC record.

Fixes: zephyrproject-rtos#43058
Signed-off-by: Mariusz Skamra <[email protected]>
RodinHaker pushed a commit to abelsensors/zephyr that referenced this issue Mar 19, 2022
@MariuszSkamra @RodinHaker
tests: bsim: unicast_server_test: Fix codec specific capabilities
4927005 
This fixes format of codec specific capabilities in PAC record.

Fixes: zephyrproject-rtos#43058
Signed-off-by: Mariusz Skamra <[email protected]>
@Thalley Thalley moved this from To do to Done in Bluetooth LE Audio Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MariuszSkamra MariuszSkamra

Labels
area: Bluetooth Audio area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
Bluetooth LE Audio
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MariuszSkamra @carlescufi