Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimxrt1050_evk: GPIO button pushed only once #45129

Closed
CarloWM opened this issue Apr 26, 2022 · 1 comment · Fixed by #45214
Closed

mimxrt1050_evk: GPIO button pushed only once #45129

CarloWM opened this issue Apr 26, 2022 · 1 comment · Fixed by #45214
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Enhancement Changes/Updates/Additions to existing features platform: NXP NXP

Comments

@CarloWM
Copy link

CarloWM commented Apr 26, 2022

Is your enhancement proposal related to a problem? Please describe.
the GPIO button can only be pushed once. than it fails to push again. this is because in the DTS the up function is missing

gpio_keys {
	compatible = "gpio-keys";
	user_button: button_0 {
		label = "User SW8";
		gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
	};
};

Describe the solution you'd like
change gpios from only GPIO_ACTIVE_LOW to pull GPIO_PULL_UP and GPIO_ACTIVE_LOW.

gpio_keys {
	compatible = "gpio-keys";
	user_button: button_0 {
		label = "User SW8";
		gpios = <&gpio5 0 (GPIO_PULL_UP | GPIO_ACTIVE_LOW)>;
	};
};

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
as alternative it is possible to make a overlay and change it there. but this has to be done by every user itself. and the samples wouldn't work out of the box.

@CarloWM CarloWM added the Enhancement Changes/Updates/Additions to existing features label Apr 26, 2022
@danieldegrasse danieldegrasse added the bug The issue is a bug, or the PR is fixing a bug label Apr 27, 2022
@danieldegrasse danieldegrasse self-assigned this Apr 27, 2022
@danieldegrasse
Copy link
Collaborator

@CarloWM verified this issue also exists on an RT1064- can you test the PR #45214 to ensure it fixes the issue for you?

carlescufi pushed a commit that referenced this issue May 2, 2022
User switch on mimxrt series boards requires a pull up resistor
to ensure the GPIO state does not float

Fixes #45129

Signed-off-by: Daniel DeGrasse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Enhancement Changes/Updates/Additions to existing features platform: NXP NXP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants