Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Probably) unnecessary branches in several modules #45241

Closed
12 of 16 tasks
mbolivar-nordic opened this issue Apr 29, 2022 · 24 comments
Closed
12 of 16 tasks

(Probably) unnecessary branches in several modules #45241

mbolivar-nordic opened this issue Apr 29, 2022 · 24 comments
Assignees
Labels
area: DevOps Developer Operations, Continuous Integration area: Modules bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale

Comments

@mbolivar-nordic
Copy link
Contributor

mbolivar-nordic commented Apr 29, 2022

Describe the bug

Several modules in the upstream west.yml file point to forks that have what look like unnecessary branches.

Each unnecessary branch:

  1. creates wasted network traffic, since west update will fetch all remote branches by default (i.e. unless west update --narrow is used)
  2. clutters the west update output for users, who see a line printed for each unnecessary branch:
=== updating some_module (modules/...):
--- some_module: fetching, need revision ########################################
From https://github.com/zephyrproject-rtos/some_module
 * [new branch]            asdfsdfsdfsdfsdf                  -> refs/west/asdfsdfsdfsdfsdf
 * [new branch]            asdfsdfsdfsdfsdf                  -> refs/west/asdfsdfsdfsdfsdf
 * [new branch]            asdfsdfsdfsdfsdf                  -> refs/west/asdfsdfsdfsdfsdf
[...]
 * [new branch]            zephyr                            -> refs/west/zephyr

To Reproduce

  1. west init zephyrproject
  2. cd zephyrproject
  3. west update
  4. see lots of clutter in the output

Expected behavior

No branches should be present in the zephyrproject-rtos GitHub organization's fork of a module repository unless the branch contains commits that are actually needed by some west.yml file in zephyr's history. (So keeping 'zephyr' and 'v1.14-branch' branches is OK, but topic branches are not OK.)

Impact

Annoyance

Logs and console output

Here is a list of modules and branches that seem probably unnecessary to me.

  • civetweb:

    • wip-ssl-error-queue
  • hal_espressif:

    • bugfix/espc32c3_eco0
    • bugfix/warning_redefinition_esp32
    • feature/clock_esp32c3
    • feature/esp32c3_ble
    • feature/esp32c3_boot_zephyr_sdk
    • feature/esp32c3_intc
    • feature/esp32c3_support
    • feature/esp32c3_wifi
    • feature/gpio_esp32c3
    • feature/intc_bt_wifi
    • feature/serial_driver_esp32c3
    • feature/spi_driver_esp32c3
    • feature/timer_driver_esp32c3
    • hal_v4.2
    • hal_v4.3
    • zephyr_v4.3
  • hal_nordic:

    • topic-nrfx-2.0.0
  • hal_nxp:

    • agansari-patch-1
  • hal_rpi_pico:

    • bugfix
    • comments_for_register_arrays
    • develop
    • doc-build
    • fix-uart-lcr-write
    • host_packed
    • irq_clear_comment
    • mutex_speed
    • pwm-comment-enable-disable
    • track_upstream_tinyusb
  • hal_xtensa:

    • RF
  • liblc3codec:

    • sneak_peek
  • lz4:

    • Makefile
    • Makefile_export
    • coverity_scan
    • dev
    • gh-pages
    • install_ln
    • lz4io
    • release
    • vs2005
  • mbedtls:

    • mbedtls_move_zephyr_files
    • tls-2.26-branch
  • mcuboot:

    • add-license
    • coverity_scan
    • inclusive_lang
    • revert-368-s1000_support
    • sim
    • suit
    • v1.3-branch
    • v1.3.1-branch
  • nanopb:

    • cifuzz_test4
    • dev_dynamic_nanopb_pb2
    • dev_markdown_docs
    • maintenance_0.1
    • maintenance_0.2
    • maintenance_0.3
  • tinycbor:

    • dev
    • gh-pages
  • TraceRecorderSource:

    • up2
  • trusted-firmware-m:

    • legacy
  • psa-arch-tests:

    • ew_beta0
    • key_derivation
    • release
    • release-attestation-1.0-beta0
    • release-crypto-mbedcrypto-1.0.0
    • v0.9_staging
  • zscilib:

    • gh-pages
@mbolivar-nordic mbolivar-nordic added the bug The issue is a bug, or the PR is fixing a bug label Apr 29, 2022
@sylvioalves
Copy link
Collaborator

@mbolivar-nordic I cleaned up hal_espressif branch.

@stephanosio stephanosio added area: DevOps Developer Operations, Continuous Integration area: Modules labels Apr 29, 2022
@mbolivar-nordic
Copy link
Contributor Author

Pinging individual module maintainers to please take a look at the above and fix their modules by removing any unnecessary branches.

@yonsch
Copy link
Contributor

yonsch commented Apr 29, 2022

hal_rpi_pico is clean

@Casper-Bonde-Bose
Copy link
Collaborator

liblc3codec is clean

@dcpleung
Copy link
Member

hal_xtensa is scrubbed.

@Navin-Sankar
Copy link
Member

lz4 is clean

@microbuilder
Copy link
Member

@mbolivar-nordic The gh-pages branch in zscilib is used to store the following documentation and host it via Github: https://zephyrproject-rtos.github.io/zscilib/ ... seems like a valid use case to have a (smaller) branch???

@stephanosio stephanosio self-assigned this May 2, 2022
@tleksell-pe
Copy link
Collaborator

@nashif the up2 branch in the TraceRecorderSource repo was created by you, does it fill any purpose or can it be deleted?

@stephanosio
Copy link
Member

The gh-pages branch in zscilib is used to store the following documentation and host it via Github:

@microbuilder Is there a separate "upstream" repository for the zscilib? or is https://github.com/zephyrproject-rtos/zscilib in itself supposed to be the upstream?

If the latter, I suppose we have no option but to leave the branch as-is since it is a special case (we usually have separate upstream repos).

@microbuilder
Copy link
Member

@stephanosio This is the 'home' repo for zsclib.

@mbolivar-nordic mbolivar-nordic added the priority: low Low impact/importance bug label May 3, 2022
@dleach02
Copy link
Member

dleach02 commented May 4, 2022

hal_nxp cleaned up

@mbolivar-nordic
Copy link
Contributor Author

Thanks to everyone who's updated so far!

Pinging the maintainers for modules which are still TODO:

@mbolivar-nordic
Copy link
Contributor Author

TraceRecorderSource: @tleksell-pe

Sorry, this should have been a ping to @nashif given this comment:

#45241 (comment)

@microbuilder
Copy link
Member

tf-m and psa-arch-test cleanup complete

@d3zd3z
Copy link
Collaborator

d3zd3z commented May 25, 2022

I've cleaned up the branches in mcuboot.

@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jul 25, 2022
@mbolivar-nordic
Copy link
Contributor Author

Pinging again:

@github-actions github-actions bot removed the Stale label Jul 26, 2022
@anangl
Copy link
Member

anangl commented Jul 26, 2022

Pinging again:

?
hal_nordic has already been cleaned up. There is only v1.14-branch there, what is okay according to this issue description. Am I missing something?

@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jul 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DevOps Developer Operations, Continuous Integration area: Modules bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale
Projects
None yet
Development

No branches or pull requests