Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample: drivers: enc28j60: Ethernet controller sample app #23730

Closed
wants to merge 1 commit into from

Conversation

jukkar
Copy link
Member

@jukkar jukkar commented Mar 24, 2020

Example how to use enc28j60 Ethernet controller.

Signed-off-by: Jukka Rissanen [email protected]

As agreed in API meeting, here is a sample for enc28j60 Ethernet controller. This initial version is using black_f407ve board as that was the only one that I had setup to use enc28j60. Other boards can be added by placing proper config files to board directory and adding whitelisting entries to sample.yaml file.

@jukkar jukkar requested a review from carlescufi March 24, 2020 19:00
@jukkar jukkar requested a review from nashif as a code owner March 24, 2020 19:00
@zephyrbot zephyrbot added the area: Samples Samples label Mar 24, 2020
Example how to use enc28j60 Ethernet controller.

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar
Copy link
Member Author

jukkar commented Mar 31, 2020

ping @nashif @carlescufi

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on API meeting today, rather than introducing a specific sample for enc28j60, can we decide which networking sample/test might make sense for ethernet? ./samples/net/sockets/echo_client/server?

@jukkar
Copy link
Member Author

jukkar commented Mar 31, 2020

Based on API meeting today, rather than introducing a specific sample for enc28j60, can we decide which networking sample/test might make sense for ethernet? ./samples/net/sockets/echo_client/server?

That is problematic as the overlay is board specific so you would have multiple overlays for enc28j60 in each sample. Also we cannot pick that said overlay automatically as there is no board that has controller by default.

@galak
Copy link
Collaborator

galak commented Mar 31, 2020

That is problematic as the overlay is board specific so you would have multiple overlays for enc28j60 in each sample. Also we cannot pick that said overlay automatically as there is no board that has controller by default.

Not sure I follow the comment about multiple overlays for each sample

We've have cases in all over the place for sensors or such that don't exist directly on a board but has a board overlay that shows how it can exist on a board (even if that requires being wired up).

@jfischer-no
Copy link
Collaborator

@jukkar I think it would be easier to add generic arduino shield support for the ENC28J60 controller, like we have it for few display controller.

@jukkar
Copy link
Member Author

jukkar commented Apr 16, 2020

I think it would be easier to add generic arduino shield support for the ENC28J60 controller, like we have it for few display controller.

Ok, makes sense. Lets close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants