Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zephyr sysbuild / multi image #40555
Zephyr sysbuild / multi image #40555
Changes from 5 commits
b1d1c24
32a28ef
a0665bf
1a71ce8
f655493
86dda45
4ec16a3
b719e15
70e05e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand there is dedicated namespace for these Kconfig properties (and will never merge to with the application properties).
For instance this property does something else than CONFIG_BOOTLOADER_MCUBOOT of zephyr-rtos app.
I want to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the help text can definitely be improved.
But whether we should invent two different setting names or have them identical as now depends a lot on how you look at this.
The Zephyr setting states:
zephyr/Kconfig.zephyr
Lines 682 to 686 in 83d73f6
and my view on this is that this is also true for the sysbuild
BOOTLOADER_MCUBOOT
because it propagates this setting to the application so that the app is chain loaded by MCUboot, as well as devicetree is setup accordingly.Not inside sysbuild itself, but in the images built by sysbuild.
Ref:
zephyr/share/sysbuild/CMakeLists.txt
Lines 33 to 37 in 70e05e2
Of course sysbuild itself does one more thing which the application itself cannot do, and that is building and flashing of MCUboot in addition.
I believe having identical name for
BOOTLOADER_MCUBOOT
makes it easier for users to transition to sysbuild and understand how to build a sample with MCUboot, and that the small addition that sysbuild provides is not sufficient to justify two different names.