Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast Audio Scan Service server and client #40671

Merged
merged 5 commits into from
Mar 10, 2022

Conversation

Thalley
Copy link
Collaborator

@Thalley Thalley commented Nov 25, 2021

Upstreams the BASS server and client from the LE Audio topic branch.

The implementation of BASS is a standalone implementation, and does not properly implement the scan delegator or broadcast assistant roles, and will require significant amount of rework once the broadcast source and broadcast sink implementations have also been upstreamed.

fixes #41593

@Thalley Thalley requested review from cvinayak and removed request for jhedberg, Vudentz, aescolar, asbjornsabo, wopu-ot and alwa-nordic November 25, 2021 14:50
@github-actions github-actions bot added area: API Changes to public APIs area: Bluetooth area: Tests Issues related to a particular existing or missing test labels Nov 25, 2021
@Thalley Thalley force-pushed the bass_upstream branch 3 times, most recently from 1cb8cd9 to 6b35aac Compare November 25, 2021 15:15
Copy link
Collaborator

@asbjornsabo asbjornsabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to fix.

@Thalley Thalley requested a review from asbjornsabo February 4, 2022 16:25
@Thalley Thalley force-pushed the bass_upstream branch 5 times, most recently from d423ab4 to 511c214 Compare February 7, 2022 13:28
asbjornsabo
asbjornsabo previously approved these changes Feb 8, 2022
Copy link
Collaborator

@asbjornsabo asbjornsabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments have been addressed.
Added one more minor comment that should be evaluated.
With that in place, I am OK to merge this.

include/bluetooth/audio/bass.h Outdated Show resolved Hide resolved
@tejlmand tejlmand removed their request for review February 10, 2022 15:14
@Thalley Thalley force-pushed the bass_upstream branch 3 times, most recently from b81b089 to 4556ea5 Compare February 23, 2022 08:55
Add the BASS as a standalone service. The service is
used for the scan delegator role, which has not been
fully implemented yet.

Signed-off-by: Emil Gydesen <[email protected]>
Add the BASS client implementation

This is a standalone implementation that
needs to be (heavily) modified for the
broadcast assistant role in the future.

Signed-off-by: Emil Gydesen <[email protected]>
Add support for the BASS server shell.

Signed-off-by: Emil Gydesen <[email protected]>
Add the BASS client shell module.

Signed-off-by: Emil Gydesen <[email protected]>
Add the BASS babbleism tests.

Signed-off-by: Emil Gydesen <[email protected]>
Copy link
Collaborator

@Casper-Bonde-Bose Casper-Bonde-Bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nashif nashif merged commit a1395c1 into zephyrproject-rtos:main Mar 10, 2022
@Thalley Thalley deleted the bass_upstream branch April 5, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: Bluetooth Audio area: Bluetooth area: Build System area: Tests Issues related to a particular existing or missing test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LE Audio: Upstream BASS
7 participants