-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcast Audio Scan Service server and client #40671
Conversation
1cb8cd9
to
6b35aac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things to fix.
89caa41
to
92343fb
Compare
d423ab4
to
511c214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments have been addressed.
Added one more minor comment that should be evaluated.
With that in place, I am OK to merge this.
511c214
to
4801d98
Compare
b81b089
to
4556ea5
Compare
Add the BASS as a standalone service. The service is used for the scan delegator role, which has not been fully implemented yet. Signed-off-by: Emil Gydesen <[email protected]>
Add the BASS client implementation This is a standalone implementation that needs to be (heavily) modified for the broadcast assistant role in the future. Signed-off-by: Emil Gydesen <[email protected]>
Add support for the BASS server shell. Signed-off-by: Emil Gydesen <[email protected]>
Add the BASS client shell module. Signed-off-by: Emil Gydesen <[email protected]>
Add the BASS babbleism tests. Signed-off-by: Emil Gydesen <[email protected]>
4556ea5
to
78035be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upstreams the BASS server and client from the LE Audio topic branch.
The implementation of BASS is a standalone implementation, and does not properly implement the scan delegator or broadcast assistant roles, and will require significant amount of rework once the broadcast source and broadcast sink implementations have also been upstreamed.
fixes #41593