twister: add option to ignore skipped tests in reports #40780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
force-pushed
the
twister/no_skipped
branch
from
cc8a7ee to
e7d4bd4
Compare
hakehuang
approved these changes
Dec 1, 2021
ceolin
reviewed
Dec 1, 2021
scripts/pylib/twister/twisterlib.py
Outdated
| # Multiple 'property' can be added to 'properties' | ||
| # differing by name and value | ||
| ET.SubElement(eleTSPropetries, 'property', name="version", value=version) | ||
| if not no_skipped or total != skips: |
There was a problem hiding this comment.
or total != skips: will not cause it showing some skipped tests ?
cfriedt
reviewed
Dec 1, 2021
scripts/pylib/twister/twisterlib.py
Outdated
| # Multiple 'property' can be added to 'properties' | ||
| # differing by name and value | ||
| ET.SubElement(eleTSPropetries, 'property', name="version", value=version) | ||
| if not no_skipped or total != skips: |
There was a problem hiding this comment.
might be able to eliminate the double-negative if you rename the variable to report_skipped.
nashif
force-pushed
the
twister/no_skipped
branch
2 times, most recently
from
b3bdfda to
682fd94
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
PerMac
requested changes
Feb 3, 2022
PerMac
previously approved these changes
Feb 3, 2022
enjiamai
previously approved these changes
Feb 3, 2022
hakehuang
previously approved these changes
Feb 6, 2022
|
@nashif please rebase |
ceolin
previously approved these changes
Mar 3, 2022
With --no-skipped-report, twister will skip over all tests marked as skipped (filtered) in the junit report. This is useful for CI where have 1000s of filtered tests that appear in the report and in some cases cause tools parsing the output to fail or provide incomplete results. Fixes zephyrproject-rtos#38179 Signed-off-by: Anas Nashif <[email protected]>
Do not report skipped tests to reduce size of report and to make it parseable. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
twister/no_skipped
branch
from
682fd94 to
cbeacb3
Compare
PerMac
approved these changes
Mar 3, 2022
enjiamai
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With --no-skipped, twister will skip over all tests marked as skipped
(filtered) in the junit report.
This is useful for CI where have 1000s of filtered tests that appear in
the report and in some cases cause tools parsing the output to fail or
provide incomplete results.
Fixes #38179
Signed-off-by: Anas Nashif [email protected]