samples: Bluetooth: Support multiple periodic synchronizations #42721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Periodic Synchronization sample to support synchronization to multiple Periodic Advertisers. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Use custom interval for Periodic Advertising. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
| @@ -130,7 +138,11 @@ static void term_cb(struct bt_le_per_adv_sync *sync, | |||
| printk("PER_ADV_SYNC[%u]: [DEVICE]: %s sync terminated\n", | |||
| bt_le_per_adv_sync_get_index(sync), le_addr); | |||
|
|
|||
| atomic_dec(&sync_count); | |||
There was a problem hiding this comment.
Sometimes term_cb function will be called, while sync_cb is not called before this.
Usually it happen when sync fails exactly after calling bt_le_per_adv_sync_create (but stnc creation function returns EXIT_SUCCESS).
There was a problem hiding this comment.
handled in line 306
cvinayak
commented
Feb 14, 2022
Comment on lines
+305
to
+306
| /* Restore sync_count */ | ||
| atomic_set(&sync_count, sync_count_prev); |
There was a problem hiding this comment.
Ok, this will not work, if many already synchronized would terminate then the sync_count will be restored to incorrect value.
|
Closing as #42518 is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Periodic Synchronization sample to support
synchronization to multiple Periodic Advertisers.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]
One hour simulation log:
periodic_sync_multiple_one_hour.log