Bluetooth: Controller: Fix missing radio_df_cte_inline_set_enabled #42757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
force-pushed
the
github_cte_rx_fix
branch
2 times, most recently
from
2970850 to
dacb31c
Compare
ppryga-nordic
requested changes
Feb 14, 2022
| lll_df_conf_cte_rx_enable(cfg->slot_durations, cfg->ant_sw_len, cfg->ant_ids, | ||
| chan_idx, CTE_INFO_IN_PAYLOAD); | ||
| cfg->cte_count = 0; | ||
| #endif /* CONFIG_BT_CTLR_DF_SCAN_CTE_RX */ | ||
| } else if (IS_ENABLED(CONFIG_BT_CTLR_DF_SUPPORT)) { |
There was a problem hiding this comment.
If I'm correct, then radio_df_cte_inline_set_enable(false) should depend on CONFIG_BT_CTLR_DF_SUPPORT.
The CONFIG_BT_CTLR_DF_SCAN_CTE_RX may be disabled while the CONFIG_BT_CTLR_DF_SUPPORT is enabled.
It will allow to synchronize with periodic advertising that includes CTE without sampling of the CTE.
It applies to all places where radio_df_cte_inline_set_enable(false) was added.
There was a problem hiding this comment.
Updated, but should radio_df_cte_inline_set_disable() be used instead of always enabled even when is_enabled is false?
Add missing radio_df_cte_inline_set_enabled(false) in the prepare of Periodic Synchronization Events when CTE reporting is disabled. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_cte_rx_fix
branch
from
dacb31c to
13a7c33
Compare
|
No associated issue for these changes, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing radio_df_cte_inline_set_enabled(false) in the
prepare of Periodic Synchronization Events when CTE
reporting is disabled.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]