modules: Zcbor #43332
modules: Zcbor #43332
Conversation
github-actions
bot
added
area: Modules
manifest
west
manifest-zcbor
and removed
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
modules/zcbor/CMakeLists.txt
Outdated
| @@ -0,0 +1,17 @@ | |||
| if(CONFIG_ZCBOR) | |||
| add_library(ZCBOR INTERFACE) | |||
There was a problem hiding this comment.
is there a specific reason for creating a ZCBOR interface lib ?
Are applications expecting to link directly to the interface lib or not, or is it just because you copied code from elsewhere.
There was a problem hiding this comment.
Yes they area supposed to link directly. And yes I have copied the code.
For example mcumgr that currently links TinyCBOR would be linking this one.
west.yml
Outdated
| - name: zcbor | ||
| remote: nordic |
There was a problem hiding this comment.
when ready to be taken out of draft we should have a Zephyr fork here: https://github.com/zephyrproject-rtos
There was a problem hiding this comment.
Yes, but that requires #43333 to go first.
modules/zcbor/Kconfig
Outdated
|
|
||
| config ZCBOR | ||
| bool "zcbor library" | ||
| depends on !MINIMAL_LIBC |
There was a problem hiding this comment.
We have to be able to use both minimal libc and newlib with zcbor. The fix here would be to add the required ranges in minimal libc.
The commit adds zcbor module to the manifest. Signed-off-by: Dominik Ermel <[email protected]>
The commit adds files for the zcbor to be built as module. Signed-off-by: Dominik Ermel <[email protected]>
|
@lairdjm can you give a +1 so we can then continue in #43878? |
| config ZEPHYR_ZCBOR_MODULE | ||
| bool | ||
|
|
||
| config ZCBOR | ||
| bool "zcbor library" | ||
| help | ||
| Enable zcbor CBOR encoder/decoder library |
There was a problem hiding this comment.
Can we add the new kconfig variables from nrf? https://github.com/nrfconnect/sdk-nrf/pull/7254/files#diff-39312aac5bf76b763c702ce6341b3adcbf3ac32d01d0a324c94daabf797a9873
There was a problem hiding this comment.
I think we can do that, yes. I wonder however if it'd be better to just have that Kconfig file in the zcbor repo and then orsource it from nrf/zephyr?
| @@ -237,6 +237,9 @@ manifest: | |||
| path: modules/tee/tf-m/psa-arch-tests | |||
| groups: | |||
| - tee | |||
| - name: zcbor | |||
| revision: 317d3c6cd6dee23a151a3e7982d8564e7e19b2e2 | |||
There was a problem hiding this comment.
Could be 0.4.0 now.
The commit adds zcbor module.