subsys/ztest: Make 1cpu tests run on CPU 0 specifically #43547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: Test Framework
|
Recreating a new PR to replace #42803 , as that seems to have gotten into some kind of weird state following a rebase. Needs re-review, obviously. |
dcpleung
previously approved these changes
Mar 8, 2022
Some hardware has "interesting" configuration like asymmetric default interrupt masking (the intel_adsp devices in particular, but x86's IO-APIC driver has tripped over this in the past too) that needs special treatment if you want to run something on "core 1" specifically, and 1cpu test cases pretty much by definition are going to have been written without SMP details in mind. Switch the logic around a tiny bit such that these test cases always run on CPU ID zero explicitly. Actually in practice this was ALMOST guaranteed to be true already, because test setup and happens serially, having been started on the main thread, which starts on CPU 0 by definition. Then the test teardown aborts all the spawned threads that might have been running on CPUs 1+, so those reach idle, and the next test case starts syncronously on the same thread (and thus CPU) where it started. But nonetheless that wasn't actually enforced, and we've found at least one simulation environment where timing conspires to break things. Signed-off-by: Andy Ross <[email protected]>
dcpleung
approved these changes
Mar 8, 2022
nashif
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hardware has "interesting" configuration like asymmetric default
interrupt masking (the intel_adsp devices in particular, but x86's
IO-APIC driver has tripped over this in the past too) that needs
special treatment if you want to run something on "core 1"
specifically, and 1cpu test cases pretty much by definition are going
to have been written without SMP details in mind. Switch the logic
around a tiny bit such that these test cases always run on CPU ID zero
explicitly.
Actually in practice this was ALMOST guaranteed to be true already,
because test setup and happens serially, having been started on the
main thread, which starts on CPU 0 by definition. Then the test
teardown aborts all the spawned threads that might have been running
on CPUs 1+, so those reach idle, and the next test case starts
syncronously on the same thread (and thus CPU) where it started. But
nonetheless that wasn't actually enforced, and we've found at least
one simulation environment where timing conspires to break things.
Signed-off-by: Andy Ross [email protected]