Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.7] X86: direct MSI message to proper processor #43690

Conversation

tbursztyka
Copy link
Collaborator

@tbursztyka tbursztyka commented Mar 11, 2022

Backport of #42480 to 2.7.

Fixes #43853

Tomasz Bursztyka added 2 commits March 11, 2022 09:24
This will centralize CPUID related accessors. There was no need for it
so far, but this is going to change.

Signed-off-by: Tomasz Bursztyka <[email protected]>
Depending on whether X2APIC is enabled or not, it will be safer to grab
such ID from the right place.

Signed-off-by: Tomasz Bursztyka <[email protected]>
@github-actions github-actions bot added area: API Changes to public APIs area: X86 x86 Architecture (32-bit) labels Mar 11, 2022
@cfriedt cfriedt changed the title Backport 42480 to v2.7 branch [v2.7] X86: direct MSI message to proper processor Mar 15, 2022
@cfriedt
Copy link
Member

cfriedt commented Mar 15, 2022

@tbursztyka - please create an issue for the backport.

When Zephyr runs directly on actual hardware, it will be always
directing MSI messages to BSP (BootStrap Processor). This was fine until
Zephyr could be ran on virtualizor that may NOT run it on BSP.

So directing MSI messages on current processor. If Zephyr runs on actual
hardware, it will be BSP since such setup is always made at boot time by
the BSP. On other use case it will be whatever is relevant at that time.

Fixes zephyrproject-rtos#43853

Signed-off-by: Tomasz Bursztyka <[email protected]>
@tbursztyka tbursztyka force-pushed the backport-42480-to-v2.7-branch branch from 304d870 to 27b3acc Compare March 16, 2022 09:36
@tbursztyka
Copy link
Collaborator Author

@cfriedt done, I added the "Fixes" line in last commit

@cfriedt cfriedt merged commit 063dbec into zephyrproject-rtos:v2.7-branch Mar 16, 2022
@jhedberg
Copy link
Member

@cfriedt done, I added the "Fixes" line in last commit

@tbursztyka @cfriedt GitHub doesn't recognize such references in commit messages. It works only by chance for single-commit PRs, since the message is replicated in the PR description (which is, AFAIK, the only place where those references are recognized). You can see this by the fact that as of writing this message the issue still isn't closed, even though this PR got merged.

@cfriedt
Copy link
Member

cfriedt commented Mar 17, 2022

#43853 is the issue ID by the looks of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: X86 x86 Architecture (32-bit)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants