Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.7-auditable] X86: direct MSI message to proper processor #43691

Conversation

tbursztyka
Copy link
Collaborator

@tbursztyka tbursztyka commented Mar 11, 2022

Backport #42480 to v2.7 auditable branch

Fixes #43854
Fixes #44797

Tomasz Bursztyka added 2 commits March 11, 2022 09:33
This will centralize CPUID related accessors. There was no need for it
so far, but this is going to change.

Signed-off-by: Tomasz Bursztyka <[email protected]>
Depending on whether X2APIC is enabled or not, it will be safer to grab
such ID from the right place.

Signed-off-by: Tomasz Bursztyka <[email protected]>
@tbursztyka
Copy link
Collaborator Author

CI failed but not because of the commits, can someone restart a CI check?

When Zephyr runs directly on actual hardware, it will be always
directing MSI messages to BSP (BootStrap Processor). This was fine until
Zephyr could be ran on virtualizor that may NOT run it on BSP.

So directing MSI messages on current processor. If Zephyr runs on actual
hardware, it will be BSP since such setup is always made at boot time by
the BSP. On other use case it will be whatever is relevant at that time.

Fixes zephyrproject-rtos#43854

Signed-off-by: Tomasz Bursztyka <[email protected]>
@tbursztyka tbursztyka force-pushed the backport-42480-to-v2.7-auditable-branch branch from 6b11db3 to 138e417 Compare March 16, 2022 09:37
@tbursztyka tbursztyka changed the title Backport 42480 to v2.7 auditable branch [v2.7-auditable] X86: direct MSI message to proper processor Mar 16, 2022
@tbursztyka
Copy link
Collaborator Author

Who is in charge of merging to 2.7-auditable? These commits have been already merged to 2.7.

@tbursztyka
Copy link
Collaborator Author

 @nashif are you able to merge this one? (I could not figure out who's in charge of this branch). Thanks

@tbursztyka
Copy link
Collaborator Author

@pqueirosint can you re-approve?

@nashif
Copy link
Member

nashif commented Apr 12, 2022

Who is in charge of merging to 2.7-auditable? These commits have been already merged to 2.7.

why do you need to merge this into this branch? it should go into 2.7 and it will be taken from there, you should not backport directly to the auditable branch.

Copy link
Member

@nashif nashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not backport directly to this branch.

@tbursztyka
Copy link
Collaborator Author

@nashif ok good to know, hard to guess an undocumented process (unless I missed it)

@tbursztyka tbursztyka closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: X86 x86 Architecture (32-bit)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants