boards: rddrone_fmuk66: correct pinmux errors #44780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaureenHelm
previously approved these changes
Apr 12, 2022
|
@danieldegrasse Could you please add some more details to the commit message. There are some more changes in this commit in addition to fixing the UART4 RTS line |
Correct the following errors in rddrone pinmux: - Pin selection for UART4 RTS line was incorrect, should use PTE27 - Pin selection for red PWM LED was incorrect, should use PTD1 - FlexCAN0/1 RX should not have pullup resistors (per prior pinmux.c settings) - FTM0_CH1_PTA4 does not require a pullup resistor - LPUART0_RX_PTD8 requires a pullup resistor for UART RX to work Fixes #44314 Signed-off-by: Daniel DeGrasse <[email protected]>
dleach02
approved these changes
Apr 12, 2022
MaureenHelm
approved these changes
Apr 12, 2022
mmahadevan108
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct errors in rddrone pinmux. Selection for UART4 RTS line was
incorrect, as was pinmux for red PWM LED.
Fixes #44314
Signed-off-by: Daniel DeGrasse [email protected]