Bluetooth: Controller: Fix instant based procedure complete event #44791
Conversation
cvinayak
force-pushed
the
github_llcp_rx_hold_fix
branch
2 times, most recently
from
5b59ba6 to
a3ad601
Compare
cvinayak
requested review from
carlescufi,
thoh-ot and
kruithofa
as code owners
| @@ -1953,6 +1979,14 @@ void ull_conn_tx_ack(uint16_t handle, memq_link_t *link, struct node_tx *tx) | |||
| pdu_tx->ll_id = PDU_DATA_LLID_RESV; | |||
| } else { | |||
| LL_ASSERT(handle != LLL_HANDLE_INVALID); | |||
|
|
|||
There was a problem hiding this comment.
Missing "if defined( CONFIG_BT_LL_SW_LLCP_LEGACY)" ?
There was a problem hiding this comment.
@erbr-ot Do I need the conditional compilation as non of the CI tests are complaining?
There was a problem hiding this comment.
Well, the rx_hold-functionality is under CONFIG_BT_LL_SW_LLCP_LEGACY is it not? So I'd expect the usage to be as well?
There was a problem hiding this comment.
I guess no builds are made with refactored LLCP AND CONFIG_BT_CTLR_RX_ENQUEUE_HOLD?
There was a problem hiding this comment.
@kruithofa can confirm, the bsim LL conformance tests run the refactored LLCP, but I do not think CONFIG_BT_CTLR_RX_ENQUEUE_HOLD would be enabled?
There was a problem hiding this comment.
@erbr-ot I have added the depends on CONFIG_BT_LL_SW_LLCP_LEGACY
cvinayak
force-pushed
the
github_llcp_rx_hold_fix
branch
from
a3ad601 to
52e0e32
Compare
cvinayak
force-pushed
the
github_llcp_rx_hold_fix
branch
from
52e0e32 to
17a1dff
Compare
Fix instant based procedure complete event generation to be held until after the on-air instant has elapsed. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Rework instant based procedure complete event generation to be held until after the on-air instant has elapsed, to have conditional compilation around the code where the event generation be held or immediately dispatched so that it improves readability. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_llcp_rx_hold_fix
branch
from
17a1dff to
d8a45f8
Compare
Fix instant based procedure complete event generation to be
held until after the on-air instant has elapsed.
Fixes #21994.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]