drivers: flash: stm32h7x: Fix wrong flash write offset #45639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrihell
force-pushed
the
issue_45568_fix_stm32h7x_flash_driver
branch
from
76ebb65 to
06f7968
Compare
FRASTM
previously approved these changes
May 16, 2022
|
@chrihell PR looks fine but please fix issues reported by the CI compliance check: |
Add specific configuration and DTS overlay files for NUCLEO-H7A3ZI-Q board to the littlefs example project. The second half of the SOC flash is used as flash partition for littlefs. Signed-off-by: Christoph Heller <[email protected]>
The flash_stm32_write_range() function of the STM32H7x flash driver partially uses a wrong flash program word size for certain SOC types when calculating the flash write offset. If the used SOC is not having a flash program word size of 256 bits / 32 bytes the written data might get corrupted, as the flash write offset value does not match the number of bytes that were actually written. Fixes zephyrproject-rtos#45568 Signed-off-by: Christoph Heller <[email protected]>
chrihell
force-pushed
the
issue_45568_fix_stm32h7x_flash_driver
branch
from
06f7968 to
1ab18bd
Compare
erwango
approved these changes
May 16, 2022
|
Fixed CI compliance check errors. Hope it's fine now. Did I force push too much or was it ok like that? |
de-nordic
approved these changes
May 17, 2022
carlescufi
approved these changes
May 18, 2022
It's all good now, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #45568
Changes:
Add specific configuration and DTS overlay files for NUCLEO-H7A3ZI-Q
board to the littlefs example project. The second half of the SOC flash
is used as flash partition for littlefs.
The flash_stm32_write_range() function of the STM32H7x flash
driver partially uses a wrong flash program word size for certain
SOC types when calculating the flash write offset. If the used
SOC is not having a flash program word size of 256 bits / 32 bytes
the written data might get corrupted, as the flash write offset
value does not match the number of bytes that were actually
written.
The fix was verified by executing the littlefs example application on a nucleo_h7a3zi_q board (uses SOC: STM32H7A3).
See issue for more details.