bluetooth: att: Fix L2CAP channel section order #45801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekPieta
requested review from
alwa-nordic,
jhedberg and
Vudentz
as code owners
github-actions
bot
added
area: Bluetooth
area: Bluetooth Host
pdunaj
previously approved these changes
May 19, 2022
ppryga-nordic
previously approved these changes
May 20, 2022
jhedberg
previously approved these changes
May 20, 2022
The L2CAP channel section is sorted lexicographically. Make sure that ATT fixed channel will be placed as the last one to ensure that SMP channel is properly initialized before bt_att_connected tries to send security request. Fixes zephyrproject-rtos#45820 Signed-off-by: Marek Pieta <[email protected]>
MarekPieta
dismissed stale reviews from jhedberg, ppryga-nordic, and pdunaj
via
007663b
ppryga-nordic
approved these changes
May 20, 2022
alwa-nordic
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The L2CAP channel section is sorted lexicographically. Make sure that ATT fixed channel will be placed as the last one to ensure
that SMP channel is properly initialized before bt_att_connected tries to send security request.
The issue can be replicated on main (used commit hash of 2dc866f) with
bluetooth/peripheral_hidssample (checked on nrf52840dk_nrf528400):Right after reconnection, the following error log is observed:
The error log is observed on every reconnection.
Fixes #45820